numbat: add initFile #7159
Open
numbat: add initFile #7159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the option initFile for initialization of numbat shell with custom units, functions and constants
|
This is my first pull request to a nixos project, so if there is any formatting or style issues, please let me know |
Aehmlo
suggested changes
May 30, 2025
|
Thanks for the PR! Looks pretty good to me overall; with the suggested change(s), I think we should be good to merge. |
Added the new types.sourceFileOrLines feature to allow for a declared source file init.nbt
awwpotato
reviewed
Jun 2, 2025
Co-authored-by: awwpotato <[email protected]>
This reverts commit c8a2905 as a variable of type sourceFileOrLines assigns source to null which is incompatible with home.file.initFile.source being an absolute path.
Merge master to pass tests
This commit fixes the broken tests
teto
requested changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option initFile for initialization of numbat shell with custom units, functions and constants
Description
Numbat has an optional ~/.config/numbat/init.nbt to define custom functions, constants, and units. This PR adds a string option to insert text into that file.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt-rfc-style keep-sorted --run treefmt.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@Aehmlo