timewarrior: init #7182
Draft
timewarrior: init #7182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prince213
force-pushed
the
push-orymwxvklmyu
branch
2 times, most recently
from
9b3aa30 to
cd245bd
Compare
cardboardcpu
suggested changes
Jun 1, 2025
| options.programs.timewarrior = { | ||
| enable = lib.mkEnableOption "Timewarrior"; | ||
| package = lib.mkPackageOption pkgs "timewarrior" { }; | ||
| taskwarrior.enable = lib.mkOption { |
There was a problem hiding this comment.
Nit: maybe naming the option something like taskwarriorHook would be oportune?
There was a problem hiding this comment.
I do have a few names in mind like this one (as it's similar to aerc.enable) and enableTaskwarriorIntegration but I'm not really sure yet.
|
@cardboardcpu Can you help fix & run the tests? I'm not sure why it fails that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt-rfc-style keep-sorted --run treefmt.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC