Skip to content

meli: support "include" statement #7248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

teto
Copy link
Collaborator

@teto teto commented Jun 9, 2025

so one can mix nix generated and manual configs

Description

This is one thing I missed from my own module. @MunsMan

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt-rfc-style keep-sorted --run treefmt.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@teto teto force-pushed the matt-push-yqtsztxtzvtm branch from 1c64f28 to 30444ba Compare June 10, 2025 08:23
so one can mix nix generated and manual configs
@teto teto force-pushed the matt-push-yqtsztxtzvtm branch from 30444ba to 009110b Compare June 10, 2025 09:38
@teto
Copy link
Collaborator Author

teto commented Jun 10, 2025

due to the recent IFD interdiction (which is cool), my initial attempt using readFile on the generated file wouldn't work.
So instead I included the generated config. Because it's less readable I disabled it when not using includes. This feels a bit hackish but this is the best way I could find to keep the best of both worlds.

@teto teto added mail and removed dev-tools labels Jun 10, 2025
@teto
Copy link
Collaborator Author

teto commented Jun 11, 2025

I will abuse my maintainer hat and merge this. Maybe I should add myself as maintainer of the module, anyway I intend to deal with the fallout

@teto teto merged commit 450f06e into nix-community:master Jun 11, 2025
4 checks passed
@teto teto deleted the matt-push-yqtsztxtzvtm branch June 11, 2025 07:57
@MunsMan
Copy link
Contributor

MunsMan commented Jun 11, 2025

Works for me, feel free to add yourself as a maintainer.

I'm currently working on more improvements on the options regarding the setup of the mail backend. I will create a PR if ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants