Skip to content

search.rs: include platforms in search results#239

Merged
viperML merged 2 commits intonix-community:masterfrom
khaneliman:platforms
Mar 25, 2025
Merged

search.rs: include platforms in search results#239
viperML merged 2 commits intonix-community:masterfrom
khaneliman:platforms

Conversation

@khaneliman
Copy link
Copy Markdown
Contributor

@khaneliman khaneliman commented Mar 23, 2025

A common use case, for me, is to find what platforms are supported by a package in nixpkgs. This returns those results in the search command. Not sure if you would rather this be gated behind a flag.

image image

A common use case for me, is to find what platforms are supported by a
package in nixpkgs. This returns those results in the search command.
To avoid a breaking change that people might not like, introducing a
`platforms` flag to gate search change.
@viperML
Copy link
Copy Markdown
Contributor

viperML commented Mar 25, 2025

Not sure if you would rather this be gated behind a flag.

As you can imagine I only use x86_64-linux. Let's gate it behind some flag that can be toggled on with an environment variable.

@khaneliman
Copy link
Copy Markdown
Contributor Author

khaneliman commented Mar 25, 2025

Would you prefer that instead of the flag I added, or in addition to?

@viperML
Copy link
Copy Markdown
Contributor

viperML commented Mar 25, 2025

I'll add the env var in a follow up commit

@viperML viperML merged commit b6a23ca into nix-community:master Mar 25, 2025
2 checks passed
@khaneliman khaneliman deleted the platforms branch March 25, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants