Skip to content

fix: get hostname consistently#244

Merged
viperML merged 1 commit intonix-community:masterfrom
magistau:hostname
Apr 3, 2025
Merged

fix: get hostname consistently#244
viperML merged 1 commit intonix-community:masterfrom
magistau:hostname

Conversation

@magistau
Copy link
Copy Markdown
Contributor

@magistau magistau commented Apr 1, 2025

Fixes #242

@magistau
Copy link
Copy Markdown
Contributor Author

magistau commented Apr 1, 2025

I'm not sure what causes the CI job to fail. Local cargo fmt thinks my code is fine; the job doesn't give any output.

@ToyVo
Copy link
Copy Markdown
Contributor

ToyVo commented Apr 2, 2025

try running the fix.sh script

src/util.rs Outdated
use std::str;

use color_eyre::{eyre, Result};
use color_eyre::{eyre, eyre::bail, eyre::Context, Result};
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I get running fix.sh in your branch

Suggested change
use color_eyre::{eyre, eyre::bail, eyre::Context, Result};
use color_eyre::{eyre, eyre::bail, Result};

@magistau magistau requested a review from ToyVo April 3, 2025 11:21
@viperML viperML merged commit 9e9a459 into nix-community:master Apr 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nh home on darwin should use same hostname logic as nh darwin

3 participants