Conversation
|
Looking forward for this fix too ! |
Member
Author
|
I'll merge this after I write some tests to make sure we never regress the |
Member
Author
|
Actually I think we need to think about a comprehensive test setup later, I'll merge this and PR nixpkgs to to make sure it gets the regression out of the way. I'll think about tests with #258 or when I change the internal structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little dirty for my taste, but it fixes the regression inbetween 3.6.0 and the 4.0.0 releases. Not sure where the regression was introduced, but from what I can tell the latest 4.0.0 beta does not have the logic to parse
--configurationso it's definitely @viperML's fault and not mine. Trust 🙏I've also made home switch a little more verbose and improved existing implementation where it caught my attention.
Fixes #262