fix: self eval passwd warning for darwin#284
Merged
NotAShelf merged 1 commit intonix-community:masterfrom May 22, 2025
Merged
Conversation
Member
Author
|
@ToyVo I have done the pr it has been 4 months with no work so here it is. |
Member
I've got no Darwin machine to test with, so I can merge this once we confirm that it resolves the original issue. Unfortunately I won't be making a release with this anytime soon because of another Darwin regression with diffs, but we can include this in 4.1.0 once I complete #280. |
Contributor
|
I thought we used conventional commits, damn |
Member
|
not anymore guess we should write some contributing guidelines after the tests PR is done |
Member
Author
Question what would that be if i only edited the src/main.rs |
Member
|
In that case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202
Tested manually full works!