Skip to content

fix: self eval passwd warning for darwin#284

Merged
NotAShelf merged 1 commit intonix-community:masterfrom
Eveeifyeve:self-eval-fix-darwin
May 22, 2025
Merged

fix: self eval passwd warning for darwin#284
NotAShelf merged 1 commit intonix-community:masterfrom
Eveeifyeve:self-eval-fix-darwin

Conversation

@Eveeifyeve
Copy link
Member

@Eveeifyeve Eveeifyeve commented May 13, 2025

Fixes #202

Tested manually full works!

@Eveeifyeve
Copy link
Member Author

@ToyVo I have done the pr it has been 4 months with no work so here it is.

@NotAShelf
Copy link
Member

  1. We do not use conventional commits, but instead scoped commits. The commit message should be module: description of changes instead.
  2. Please also update the changelog found in the project root.

I've got no Darwin machine to test with, so I can merge this once we confirm that it resolves the original issue. Unfortunately I won't be making a release with this anytime soon because of another Darwin regression with diffs, but we can include this in 4.1.0 once I complete #280.

@viperML
Copy link
Contributor

viperML commented May 13, 2025

I thought we used conventional commits, damn

@NotAShelf
Copy link
Member

not anymore :trollface:

guess we should write some contributing guidelines after the tests PR is done

@Eveeifyeve
Copy link
Member Author

  1. We do not use conventional commits, but instead scoped commits. The commit message should be module: description of changes instead.

Question what would that be if i only edited the src/main.rs

@NotAShelf
Copy link
Member

In that case nh: ... is fine.

@NotAShelf NotAShelf merged commit 54b878f into nix-community:master May 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nh clean all on darwin

3 participants