fix: preserve environment variables after self_elevate()#290
Merged
NotAShelf merged 1 commit intonix-community:masterfrom May 18, 2025
Merged
fix: preserve environment variables after self_elevate()#290NotAShelf merged 1 commit intonix-community:masterfrom
NotAShelf merged 1 commit intonix-community:masterfrom
Conversation
Member
|
LGTM. Hoping there aren't any side-effects that I cannot think of right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #289
Some environment variables such as
NH_NO_CHECKSmodify the behaviour of commands that require elevated privileges such asnh clean all. This fix allows all environment variables to be preserved after the call toself_elevate().