Skip to content

treewide: fix nvd diffs and internal cleanup#296

Merged
NotAShelf merged 4 commits intomasterfrom
fix-diffs
May 22, 2025
Merged

treewide: fix nvd diffs and internal cleanup#296
NotAShelf merged 4 commits intomasterfrom
fix-diffs

Conversation

@NotAShelf
Copy link
Member

This'll create some merge conflicts, but I'd like to get this fixed before I take an extended break. Fixes nvd diffs and supresses a redundant argument that would occur after #208. Also improves debug logging for references that we need to keep track of. Should help track down issues such as this one easier in the future.

CC @khaneliman for Darwin testing, seems to be working as intended on NixOS- testing for Home Manager would also be great.

@NotAShelf NotAShelf requested a review from viperML May 21, 2025 19:41
@NotAShelf
Copy link
Member Author

Also CC @viperML because I'd like to mark this as the last PR for 4.1.0, it gets the known regressions out of the way and brings the new Darwin activation stuff into a release, which we'll need to hurry up with.

@NotAShelf NotAShelf changed the title treewide: fix nvd diffs and internala cleanup treewide: fix nvd diffs and internal cleanup May 21, 2025
@khaneliman
Copy link
Contributor

Diff is working for me on darwin on this branch

@viperML
Copy link
Contributor

viperML commented May 22, 2025

I don't know if we are turning the codebase into some spaguetti, but the priority is to fix the diffs.

@NotAShelf
Copy link
Member Author

I don't know if we are turning the codebase into some spaguetti, but the priority is to fix the diffs.

I'll do some actual cleanup after 4.1.0, just interested in getting 4.1.0 out of the way before sit down for a potentially large refactor. #281 is still a priority, but it'll take me a little while.

@NotAShelf NotAShelf merged commit 27a7939 into master May 22, 2025
5 checks passed
@github-actions github-actions bot deleted the fix-diffs branch July 1, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants