Conversation
This was
linked to
issues
Jun 5, 2025
Closed
faukah
reviewed
Jun 5, 2025
cole-h
approved these changes
Jun 5, 2025
Member
cole-h
left a comment
cole-h
left a comment
There was a problem hiding this comment.
Looks good to me, and seems to work just fine in my brief testing! Thanks!
faukah
approved these changes
Jun 6, 2025
Member
Author
|
Actually, I think I want to add some regression tests while I'm at it. Property testing is probably not enough. |
stdlib has a clean alternative since Rust 1.70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Nix environment checks to a trait-based, less monolithic design to avoid redundant feature checks for commands that don't require checked features in the first place. There is a performance impact, but in my experience it is... not noticable as per my testing.
Regardless I think this is more robust in design, and introduces further future-proofing the current implementation is not fully capable of. Also provides groundwork for supporting more Nix variants in the future cleanly, without utility functions to check everything one-by-one.
Fixes #305, #309
Closes #315