Conversation
99f5222 to
77f3554
Compare
0e52359 to
fa806da
Compare
fa806da to
c1a53b6
Compare
|
Okay I'm pretty positive that this works as intended now. CC @khaneliman for Darwin testing if possible, I've fixed Darwin tests but can't quite tell if environment handling is optimal for Darwin systems. |
|
Please also add NIXOS_INSTALL_BOOTLOADER to the default preserved list. And also, we need to make sure it is also preserved by sudo, so that we can set this variable to install the bootloader when switching configuration. |
|
Good catch, thank you @hezhenxing. |
|
ahh this pr was merged?? |
|
No the PR is very much still open until I get a review. |
|
Appears to be working for me on darwin |
|
Looks like viper is not reviewing this one, so merge on green it is. |
|
@khaneliman I'll try to review your PR over this week. I'm a little too busy with work, but I'll take a look the first chance I get. |
Safer, cleaner environment handling to fine-grain what is preserved. The goal is to allow specifying similar fine-graining for each command.
Fixes #314