Skip to content

commands: better env handling#328

Merged
NotAShelf merged 9 commits intomasterfrom
better-env-handling
Jul 14, 2025
Merged

commands: better env handling#328
NotAShelf merged 9 commits intomasterfrom
better-env-handling

Conversation

@NotAShelf
Copy link
Member

Safer, cleaner environment handling to fine-grain what is preserved. The goal is to allow specifying similar fine-graining for each command.

Fixes #314

@NotAShelf NotAShelf force-pushed the better-env-handling branch from fa806da to c1a53b6 Compare July 8, 2025 10:00
@NotAShelf NotAShelf marked this pull request as ready for review July 8, 2025 11:10
@NotAShelf
Copy link
Member Author

Okay I'm pretty positive that this works as intended now. CC @khaneliman for Darwin testing if possible, I've fixed Darwin tests but can't quite tell if environment handling is optimal for Darwin systems.

@NotAShelf NotAShelf requested a review from viperML July 8, 2025 11:12
@hezhenxing
Copy link

Please also add NIXOS_INSTALL_BOOTLOADER to the default preserved list. And also, we need to make sure it is also preserved by sudo, so that we can set this variable to install the bootloader when switching configuration.

@NotAShelf
Copy link
Member Author

Good catch, thank you @hezhenxing.

@kagurazakei
Copy link

ahh this pr was merged??
can i use the main branch again??

@NotAShelf
Copy link
Member Author

No the PR is very much still open until I get a review.

@khaneliman
Copy link
Contributor

Appears to be working for me on darwin

@NotAShelf
Copy link
Member Author

Looks like viper is not reviewing this one, so merge on green it is.

@NotAShelf NotAShelf merged commit 183d235 into master Jul 14, 2025
7 checks passed
@NotAShelf
Copy link
Member Author

@khaneliman I'll try to review your PR over this week. I'm a little too busy with work, but I'll take a look the first chance I get.

@github-actions github-actions bot deleted the better-env-handling branch September 1, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nh clean all "$HOME is not owned by you"

4 participants