nixos: implement hints for failing units on activation

.gitignore

@@ -1,7 +1,7 @@
 # Rust
 target
-gen*
-!generations.rs
+/comp
+/man
 
 # Nix
 .direnv

CHANGELOG.md

@@ -3,7 +3,7 @@
 # NH Changelog
 
 <!--
-This is the Nh changelog. It aims to describe changes that occurred within the
+This is the NH changelog. It aims to describe changes that occurred within the
 codebase, to the extent that concerns *both users and contributors*. If you are
 a contributor, please add your changes under the "Unreleased" section as tags
 will be created at the discretion of maintainers. If your changes fix an
@@ -18,7 +18,6 @@ functionality, under the "Removed" section.
 
 ### Changed
 
-- `nh completions` now supports [nushell](https://www.nushell.sh/)
 - `nh os info` now hides empty columns.
 - `nh os info` now support `--fields` to select which field(s) to display; also
   add a per-generation "Closure Size" coloumn.
@@ -37,11 +36,26 @@ functionality, under the "Removed" section.
   different.
 - `nh os info` now hides empty fields by default, they can be explicitly shown
   via the `--fields` flag.
+- `nh completions` now supports [nushell](https://www.nushell.sh/)
+- `nh os switch` now accepts a `--show-systemctl-hints` flag that displays
+  failing systemd units at the end of the rebuild log. This flag can be used to
+  replicate the activation behaviour from `nixos-rebuild` where failing units
+  are displayed at the end.
+  - NH also allows making this the global default by setting
+    `NH_SHOW_SYSTEMCTL_HINTS`. This is useful if you miss the behaviour from
+    `nixos-rebuild` where this is default without a way of suppressing those.
 
 ### Fixed
 
-- Fixed the whitespace splitting of self-elevated commands so spaces inside quotes
-  don't get separated.
+- Fixed the whitespace splitting of self-elevated commands so spaces inside
+  quotes don't get separated.
+
+### Removed
+
+- Shell completion generation has been moved OUT of the main NH CLI, and is now
+  done via `cargo-xtask` in the packaging step. The `nh completions` command is
+  now fully deprecated and shell completion can be done with
+  `cargo xtask completions` or `cargo xtask dist`.
 
 ## 4.2.0
 

Cargo.toml

@@ -30,13 +30,11 @@ anstyle = "1.0.13"
 chrono = "0.4.42"
 clap.workspace = true
 clap-verbosity-flag = { version = "3.0.4", features = [ "tracing" ], default-features = false }
-clap_complete = "4.5.61"
-clap_complete_nushell = "4.5.10"
 color-eyre = { default-features = false, features = [ "track-caller" ], version = "0.6.5" }
 dix = "1.3.0"
 elasticsearch-dsl = "0.4.24"
 hostname = "0.4.1"
-hotpath = { version = "0.6", optional = true }
+hotpath = { version = "0.6.0", optional = true }
 humantime = "2.3.0"
 inquire = { default-features = false, version = "0.9.1", features = [ "crossterm" ] }
 nix = { default-features = false, features = [ "fs", "user" ], version = "0.30.1" }
@@ -90,6 +88,7 @@ style      = { level = "warn", priority = -1 }
 # enable those to keep our sanity.
 absolute_paths                 = "allow"
 arbitrary_source_item_ordering = "allow"
+enum_variant_names             = "allow"
 implicit_return                = "allow"
 missing_docs_in_private_items  = "allow"
 non_ascii_literal              = "allow"
@@ -102,7 +101,6 @@ std_instead_of_core            = "allow"
 too_long_first_doc_paragraph   = "allow"
 too_many_lines                 = "allow"
 unused_trait_names             = "allow"
-enum_variant_names             = "allow"
 
 # In the honor of a recent Cloudflare regression
 # Let's get rid of them, what the hell