remote: fix showing of activation logs

[faukah]

Closes #531.
The issue was that you cannot pass Redirection::Merge to both stdout and stdin.

• Added a print statement so stdout gets printed upon activation; AFAIK there is nothing relevant on stderr so we only print that if activation fails.
• Disabled failing darwin test

Sanity Checking

• I have updated the changelog as per my changes
• I have tested, and self-reviewed my code
• Style and consistency
  • I ran nix fmt to format my Nix code
  • I ran cargo fmt to format my Rust code
  • I have added appropriate documentation to new code
  • My changes are consistent with the rest of the codebase
• Correctness
  • I ran cargo clippy and fixed any new linter warnings.
• If new changes are particularly complex:
  • My code includes comments in particularly complex areas to explain the
    logic
  • I have documented the motive for those changes in the PR body or commit
    description.
• Tested on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin

---

Add a 👍 reaction to pull requests you find important.

Summary by CodeRabbit

• Bug Fixes

  • Improved how remote command logs are surfaced for elevated operations so stdout logs are displayed reliably to the user while preserving existing error reporting.

• Tests

  • Added additional skips for a Darwin-specific test to avoid running it on macOS environments.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Removed merging redirections for remote activation logs; stdout is now captured and printed after the remote activation command completes when config.show_logs is enabled. Error handling continues to use captured stderr for failure messages.

Changes

Cohort / File(s)	Summary
Remote activation output handling src/remote.rs	Removed simultaneous Redirection::Merge for both stdout and stderr during remote activation. When config.show_logs is true, the remote command's stdout is captured and printed after execution; failure path still reports capture.stderr_str().
Darwin test skips package.nix	Added additional skips for test_build_sudo_cmd_with_nix_config_spaces in Darwin test configurations (two new skip entries).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• treewide: refactor --build-host to use remote build semantics #497: Modifies the same remote activation code (src/remote.rs - activate_nixos_remote), likely related to log/redirection handling.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	❓ Inconclusive	The package.nix change disables a Darwin test (test_build_sudo_cmd_with_nix_config_spaces) which appears tangential to the main remote activation logs fix, but may be necessary to maintain test suite stability during this change.	Clarify why the Darwin test skip in package.nix is necessary and whether it's directly related to fixing the --show-activation-logs issue, or if it should be in a separate PR.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'remote: fix showing of activation logs' directly corresponds to the main change in src/remote.rs, which fixes the display of activation logs by printing stdout instead of using invalid Redirection::Merge.
Linked Issues check	✅ Passed	The PR successfully addresses #531 by fixing the Redirection::Merge error in the activate_nixos_remote function, allowing --show-activation-logs to work correctly on remote deployments.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[NotAShelf]

I believe in the heart of the cards.

FWIW this2ll change when hide by default behaviour changes to show by default and hide on demand.