Closed
Conversation
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughRemoves per-build Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant CLI as Client (CLI)
participant Rebuilder as OsRebuildArgs
participant Builder as Build System / Nix
participant Remote as Remote Host (SSH)
participant Store as Nix Store
CLI->>Rebuilder: invoke build_and_maybe_activate(variant, attrs, elevation)
Rebuilder->>Builder: execute_build(toplevel, out_path)
alt remote hosts involved
Builder->>Remote: upload/store paths / trigger remote build
Remote->>Builder: build result (store path)
else local build
Builder->>Store: build to local store path
Store-->>Builder: store path
end
Builder-->>Rebuilder: optional built path
alt variant requires activation (Boot/Test/Switch)
Rebuilder->>Remote: if remote, run activation remotely
Rebuilder->>Store: if local, perform activation (switch/test/boot)
Rebuilder-->>CLI: activation result / instructions
else build-only
Rebuilder-->>CLI: build result / VM instructions
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
faukah
force-pushed
the
general-cleanup
branch
from
ce8bcd7 to
d040081
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
Verify each finding against the current code and only fix it if needed.
In `@src/home.rs`:
- Around line 266-283: The current check in src/home.rs rejects any attribute
path that starts with "homeConfigurations"; change the logic to mirror
nixos/darwin: when attribute[0] == "homeConfigurations" allow attribute.len() ==
2 (i.e., two-element paths like ["homeConfigurations","name"]) but bail only if
attribute.len() > 2 with the existing error message that uses
attribute.join(".") and attribute.get(1).unwrap_or(...); update the conditional
around attribute[0] == "homeConfigurations" to check length and only reject
overly-specific paths while permitting exactly two-element paths.
In `@src/interface.rs`:
- Around line 129-137: Add a user warning when activation-only flags are
supplied to the Build variant: detect OsSubcommand::Build carrying OsRebuildArgs
and check the activation-only fields (show_activation_logs, install_bootloader,
no_validate, target_host) on that OsRebuildArgs; if any are set, emit the same
style of warning used for the existing --ask/--dry warning so users know those
flags will be ignored for Build. Locate the Build match arm handling
OsSubcommand::Build in interface.rs and add the check and warning there, reusing
the same logger/message format used for the ask/dry warning.
In `@src/nixos.rs`:
- Around line 408-419: The current conditional treats OsSubcommand::Build the
same as BuildVm, causing a misleading "--ask has no effect as dry run was
requested" warning and a duplicate warning for Build; change the logic so the
outer if checks only for dry run or VM variant (e.g., if self.common.dry ||
matches!(variant, BuildVm)), but move the warn!("--ask has no effect as dry run
was requested") inside the self.common.dry branch (only emit when
self.common.dry is true and self.common.ask), and keep the VM instructions logic
as if matches!(variant, BuildVm) && !self.common.dry {
print_vm_instructions(&out_path); } to avoid duplicate/misleading warnings for
Build while preserving VM behavior.
- Around line 438-639: activate_rebuilt_config is large and duplicates
RemoteHost::parse calls; refactor by extracting the local and remote activation
branches into helper methods (e.g., perform_local_activation and
perform_remote_activation) and parse the target host once into a local variable
when self.target_host.is_some() to reuse across the Test/Switch and Boot/Switch
branches; update calls that currently invoke RemoteHost::parse(target_host)
(seen in activate_rebuilt_config and the remote::activate_remote invocations) to
use the single parsed RemoteHost, and move variant-specific command construction
and elevation logic into the new helpers to reduce nesting and duplication while
preserving behavior for Test, Switch, and Boot.
- Around line 537-586: The duplicate debug messages are caused because the debug
block inside the if let Test | Switch branch logs "Completed {variant:?}..." for
Switch and then the final unconditional debug at the end logs the same message
again; remove (or move) the debug calls inside the Test | Switch branch (the
debug that references actual_store_path and out_path) so only the final
end-of-method debug remains (keep the final debug that uses
actual_store_path/out_path), or alternatively change the inner debug to only run
for Test by checking variant == Test; refer to the match/branch using Test,
Switch, Boot, the local variables actual_store_path and out_path, and the debug!
macro.
🧹 Nitpick comments (3)
🤖 Fix all nitpicks with AI agents
Verify each finding against the current code and only fix it if needed. In `@src/interface.rs`: - Around line 129-137: Add a user warning when activation-only flags are supplied to the Build variant: detect OsSubcommand::Build carrying OsRebuildArgs and check the activation-only fields (show_activation_logs, install_bootloader, no_validate, target_host) on that OsRebuildArgs; if any are set, emit the same style of warning used for the existing --ask/--dry warning so users know those flags will be ignored for Build. Locate the Build match arm handling OsSubcommand::Build in interface.rs and add the check and warning there, reusing the same logger/message format used for the ask/dry warning. In `@src/nixos.rs`: - Around line 438-639: activate_rebuilt_config is large and duplicates RemoteHost::parse calls; refactor by extracting the local and remote activation branches into helper methods (e.g., perform_local_activation and perform_remote_activation) and parse the target host once into a local variable when self.target_host.is_some() to reuse across the Test/Switch and Boot/Switch branches; update calls that currently invoke RemoteHost::parse(target_host) (seen in activate_rebuilt_config and the remote::activate_remote invocations) to use the single parsed RemoteHost, and move variant-specific command construction and elevation logic into the new helpers to reduce nesting and duplication while preserving behavior for Test, Switch, and Boot. - Around line 537-586: The duplicate debug messages are caused because the debug block inside the if let Test | Switch branch logs "Completed {variant:?}..." for Switch and then the final unconditional debug at the end logs the same message again; remove (or move) the debug calls inside the Test | Switch branch (the debug that references actual_store_path and out_path) so only the final end-of-method debug remains (keep the final debug that uses actual_store_path/out_path), or alternatively change the inner debug to only run for Test by checking variant == Test; refer to the match/branch using Test, Switch, Boot, the local variables actual_store_path and out_path, and the debug! macro.src/nixos.rs (2)
438-639:activate_rebuilt_config— activation logic is sound but the method is large.The method handles confirmation, remote copy, validation, profile resolution, and activation for three variants (
Test,Switch,Boot) across local and remote paths. The control flow is correct —Switchruns both theTest | SwitchandBoot | Switchblocks, mirroring standardnixos-rebuild switchbehavior.A few observations for future consideration:
- The method is ~200 lines with multiple nested conditionals and variant-based branches. Extracting the local vs. remote activation into helper methods would improve readability.
RemoteHost::parse(target_host)is called up to 3 times (lines 463, 539, 590) for theSwitchvariant — could be resolved once and reused.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/nixos.rs` around lines 438 - 639, activate_rebuilt_config is large and duplicates RemoteHost::parse calls; refactor by extracting the local and remote activation branches into helper methods (e.g., perform_local_activation and perform_remote_activation) and parse the target host once into a local variable when self.target_host.is_some() to reuse across the Test/Switch and Boot/Switch branches; update calls that currently invoke RemoteHost::parse(target_host) (seen in activate_rebuilt_config and the remote::activate_remote invocations) to use the single parsed RemoteHost, and move variant-specific command construction and elevation logic into the new helpers to reduce nesting and duplication while preserving behavior for Test, Switch, and Boot.
537-586: Duplicate debug logging for theSwitchvariant.For
Switch, bothif let Test | Switch(line 537) andif let Boot | Switch(line 588) blocks execute. The debug log at lines 576-585 fires inside the first block, then lines 631-637 fire again unconditionally at the end of the method. This results in two identical "Completed Switch operation..." messages.Consider removing the debug log inside the
Test | Switchblock (lines 576-585) since the one at lines 631-637 covers all activation variants.Also applies to: 631-637
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/nixos.rs` around lines 537 - 586, The duplicate debug messages are caused because the debug block inside the if let Test | Switch branch logs "Completed {variant:?}..." for Switch and then the final unconditional debug at the end logs the same message again; remove (or move) the debug calls inside the Test | Switch branch (the debug that references actual_store_path and out_path) so only the final end-of-method debug remains (keep the final debug that uses actual_store_path/out_path), or alternatively change the inner debug to only run for Test by checking variant == Test; refer to the match/branch using Test, Switch, Boot, the local variables actual_store_path and out_path, and the debug! macro.src/interface.rs (1)
129-137: Clean type consolidation — OsRebuildActivateArgs removed, variants now use OsRebuildArgs directly.The flattening is correct. The
uses_flakes()call at line 132 now resolves directly onOsRebuildArgs(defined at line 274), matching the unified type carried bySwitch,Boot, andTest.One minor observation: the
Buildvariant (line 179) now carriesOsRebuildArgswhich includes activation-only fields likeshow_activation_logs,install_bootloader,no_validate, andtarget_host. These are silently ignored forBuild, which is fine, but users may pass them without realizing they have no effect. Consider emitting a warning similar to the--ask/--drywarning at line 85 if activation-specific flags are set forBuild.Also applies to: 170-176
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/interface.rs` around lines 129 - 137, Add a user warning when activation-only flags are supplied to the Build variant: detect OsSubcommand::Build carrying OsRebuildArgs and check the activation-only fields (show_activation_logs, install_bootloader, no_validate, target_host) on that OsRebuildArgs; if any are set, emit the same style of warning used for the existing --ask/--dry warning so users know those flags will be ignored for Build. Locate the Build match arm handling OsSubcommand::Build in interface.rs and add the check and warning there, reusing the same logger/message format used for the ask/dry warning.
Comment on lines
266
to
283
| if !attribute.is_empty() { | ||
| // Check if the path is too specific | ||
| if attribute[0] == "homeConfigurations" { | ||
| if attribute.len() > 2 { | ||
| bail!( | ||
| "Attribute path is too specific: {}. Home Manager only allows \ | ||
| configuration names. Please either:\n 1. Use the flake \ | ||
| reference without attributes (e.g., '.')\n 2. Specify only \ | ||
| the configuration name (e.g., '.#{}')", | ||
| attribute.join("."), | ||
| attribute.get(1).unwrap_or(&"<unknown>".to_string()) | ||
| ); | ||
| } | ||
| } else if attribute.len() > 1 { | ||
| // User provided ".#myconfig" or similar - prepend homeConfigurations | ||
| attribute.insert(0, String::from("homeConfigurations")); | ||
| // Re-validate after prepending | ||
| if attribute.len() > 2 { | ||
| bail!( | ||
| "Attribute path is too specific: {}. Home Manager only allows \ | ||
| configuration names. Please either:\n 1. Use the flake \ | ||
| reference without attributes (e.g., '.')\n 2. Specify only \ | ||
| the configuration name (e.g., '.#{}')", | ||
| attribute.join("."), | ||
| attribute.get(1).unwrap_or(&"<unknown>".to_string()) | ||
| ); | ||
| } | ||
| bail!( | ||
| "Attribute path is too specific: {}. Home Manager only allows \ | ||
| configuration names. Please either:\n 1. Use the flake \ | ||
| reference without attributes (e.g., '.')\n 2. Specify only the \ | ||
| configuration name (e.g., '.#{}')", | ||
| attribute.join("."), | ||
| attribute.get(1).unwrap_or(&"<unknown>".to_string()) | ||
| ); | ||
| } | ||
|
|
||
| debug!( | ||
| "Using explicit attribute path from installable: {:?}", | ||
| attribute | ||
| "Using explicit attribute path from installable: {}", | ||
| attribute.join(".") | ||
| ); | ||
| return Ok(res); |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cd /tmp && git log --oneline -n 20 -- src/home.rs 2>/dev/null || echo "Git not available or file not in repo"Repository: nix-community/nh
Length of output: 97
🏁 Script executed:
# Search for attribute handling patterns in nixos.rs and darwin.rs
rg -n -A 20 'if attribute\[0\] == "nixosConfigurations"' src/nixos.rsRepository: nix-community/nh
Length of output: 909
🏁 Script executed:
rg -n -A 20 'if attribute\[0\] == "darwinConfigurations"' src/darwin.rsRepository: nix-community/nh
Length of output: 940
🏁 Script executed:
# Also check the context around line 279-283 in home.rs to see the alternative code path
sed -n '266,290p' src/home.rsRepository: nix-community/nh
Length of output: 898
🏁 Script executed:
# Look for any condition checking attribute length for homeConfigurations
rg -n -B 5 -A 15 'homeConfigurations' src/home.rsRepository: nix-community/nh
Length of output: 1581
Fix attribute length check for homeConfigurations paths to match nixosConfigurations and darwinConfigurations behavior.
The current code unconditionally rejects any path starting with homeConfigurations, but nixos.rs (lines 1215–1230) and darwin.rs (lines 284–304) both allow 2-element paths (e.g., ["nixosConfigurations", "hostname"]) and only reject longer ones. The home.rs code should do the same:
if attribute[0] == "homeConfigurations" {
if attribute.len() == 2 {
// homeConfigurations.configname - fine
} else if attribute.len() > 2 {
bail!(...)
}
}
Currently, users passing .#homeConfigurations.myuser get rejected, while the nixos and darwin modules accept the equivalent .#nixosConfigurations.hostname.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/home.rs` around lines 266 - 283, The current check in src/home.rs rejects
any attribute path that starts with "homeConfigurations"; change the logic to
mirror nixos/darwin: when attribute[0] == "homeConfigurations" allow
attribute.len() == 2 (i.e., two-element paths like
["homeConfigurations","name"]) but bail only if attribute.len() > 2 with the
existing error message that uses attribute.join(".") and
attribute.get(1).unwrap_or(...); update the conditional around attribute[0] ==
"homeConfigurations" to check length and only reject overly-specific paths while
permitting exactly two-element paths.
Comment on lines
+408
to
+419
| if self.common.dry || matches!(variant, Build | BuildVm) { | ||
| if self.common.ask { | ||
| warn!("--ask has no effect as dry run was requested"); | ||
| } | ||
|
|
||
| // For VM builds, print instructions on how to run the VM | ||
| if matches!(variant, BuildVm) && !self.common.dry { | ||
| print_vm_instructions(&out_path); | ||
| } | ||
|
|
||
| return Ok(()); | ||
| } |
There was a problem hiding this comment.
Misleading warning text for non-dry Build variant.
When variant is Build (not a dry run), the condition at line 408 is true because of matches!(variant, Build | BuildVm), but the warning at line 410 says "--ask has no effect as dry run was requested". For the Build subcommand, this isn't a dry run — it's a build-only command where activation isn't performed.
Note that for OsSubcommand::Build, a warning is already emitted at lines 84-86 in the dispatch, so this would also be a duplicate warning.
Suggested fix
if self.common.dry || matches!(variant, Build | BuildVm) {
- if self.common.ask {
- warn!("--ask has no effect as dry run was requested");
+ if self.common.ask && self.common.dry {
+ warn!("--ask has no effect as dry run was requested");
}
// For VM builds, print instructions on how to run the VM📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if self.common.dry || matches!(variant, Build | BuildVm) { | |
| if self.common.ask { | |
| warn!("--ask has no effect as dry run was requested"); | |
| } | |
| // For VM builds, print instructions on how to run the VM | |
| if matches!(variant, BuildVm) && !self.common.dry { | |
| print_vm_instructions(&out_path); | |
| } | |
| return Ok(()); | |
| } | |
| if self.common.dry || matches!(variant, Build | BuildVm) { | |
| if self.common.ask && self.common.dry { | |
| warn!("--ask has no effect as dry run was requested"); | |
| } | |
| // For VM builds, print instructions on how to run the VM | |
| if matches!(variant, BuildVm) && !self.common.dry { | |
| print_vm_instructions(&out_path); | |
| } | |
| return Ok(()); | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/nixos.rs` around lines 408 - 419, The current conditional treats
OsSubcommand::Build the same as BuildVm, causing a misleading "--ask has no
effect as dry run was requested" warning and a duplicate warning for Build;
change the logic so the outer if checks only for dry run or VM variant (e.g., if
self.common.dry || matches!(variant, BuildVm)), but move the warn!("--ask has no
effect as dry run was requested") inside the self.common.dry branch (only emit
when self.common.dry is true and self.common.ask), and keep the VM instructions
logic as if matches!(variant, BuildVm) && !self.common.dry {
print_vm_instructions(&out_path); } to avoid duplicate/misleading warnings for
Build while preserving VM behavior.
faukah
force-pushed
the
general-cleanup
branch
from
d040081 to
db343b7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
src/home.rs (1)
266-283:⚠️ Potential issue | 🟠 MajorRestore explicit Home configuration attribute handling.
Line 266+ now rejects
homeConfigurations.<name>and returns early for other non-empty attributes, which can break explicit config selection and skipactivationPackagesuffixing whenpush_drvis true.Suggested fix
if !attribute.is_empty() { - // Check if the path is too specific - if attribute[0] == "homeConfigurations" { - bail!( - "Attribute path is too specific: {}. Home Manager only allows \ - configuration names. Please either:\n 1. Use the flake \ - reference without attributes (e.g., '.')\n 2. Specify only the \ - configuration name (e.g., '.#{}')", - attribute.join("."), - attribute.get(1).unwrap_or(&"<unknown>".to_string()) - ); - } - - debug!( - "Using explicit attribute path from installable: {}", - attribute.join(".") - ); - return Ok(res); + if attribute[0] == "homeConfigurations" { + if attribute.len() > 2 { + bail!( + "Attribute path is too specific: {}. Home Manager only allows \ + configuration names. Please either:\n 1. Use the flake \ + reference without attributes (e.g., '.')\n 2. Specify only the \ + configuration name (e.g., '.#{}')", + attribute.join("."), + attribute.get(1).unwrap_or(&"<unknown>".to_string()) + ); + } + } else if attribute.len() == 1 { + attribute.insert(0, String::from("homeConfigurations")); + } + + if push_drv { + attribute.extend(toplevel.clone()); + } + debug!("Using explicit attribute path from installable: {}", attribute.join(".")); + return Ok(res); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/home.rs` around lines 266 - 283, The current block prematurely bails on attribute paths starting with "homeConfigurations" and returns early for any non-empty attribute, which prevents selecting explicit configurations and prevents adding the activationPackage suffix when push_drv is true; update the logic in the attribute-handling section to allow explicit "homeConfigurations.<name>" by extracting the configuration name from attribute[1] when present (falling back to a clear error only if the name is missing), avoid the unconditional return Ok(res) for non-empty attributes, and instead set/modify res appropriately so downstream code can append the activationPackage suffix when push_drv is true (referencing variables/values attribute, res, push_drv, and activationPackage).src/nixos.rs (1)
412-415:⚠️ Potential issue | 🟡 MinorFix misleading
--askwarning for non-dry build flows.At Line 414, the warning says dry run was requested, but this branch also executes for non-dry
Build/BuildVm. ForBuild, it also duplicates the warning already emitted inrun(Line 84–86).Suggested fix
- if self.common.dry || matches!(variant, Build | BuildVm) { - if self.common.ask { + if self.common.dry || matches!(variant, BuildVm) { + if self.common.dry && self.common.ask { warn!("--ask has no effect as dry run was requested"); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/nixos.rs` around lines 412 - 415, The warning currently fires when either self.common.dry is true or variant matches Build|BuildVm, which produces a misleading message and duplicates the warning already emitted for Build flows; change the condition so the warn!("--ask has no effect as dry run was requested") is only executed when self.common.dry && self.common.ask are both true (i.e., only for actual dry runs), and remove/avoid emitting it for the matches!(variant, Build | BuildVm) branch to prevent duplication with the existing warning emitted earlier in run.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/nixos.rs`:
- Around line 580-589: The premature/duplicate "Completed {variant:?}" debug
logs should be removed from the early branch so completion is only logged after
boot activation finishes; specifically, remove or defer the debug! calls that
print "Completed {variant:?} operation with store path: {store_path:?}" / "with
local output path: {out_path:?}" that occur when actual_store_path is Some/None
and instead emit a single debug! after the activation/boot path completes (the
later completion log around the Switch activation code). Update the activation
flow around the Switch handling to log once (using the existing completion
message) after the boot activation/activation_result code paths finish to avoid
reporting success prematurely.
---
Duplicate comments:
In `@src/home.rs`:
- Around line 266-283: The current block prematurely bails on attribute paths
starting with "homeConfigurations" and returns early for any non-empty
attribute, which prevents selecting explicit configurations and prevents adding
the activationPackage suffix when push_drv is true; update the logic in the
attribute-handling section to allow explicit "homeConfigurations.<name>" by
extracting the configuration name from attribute[1] when present (falling back
to a clear error only if the name is missing), avoid the unconditional return
Ok(res) for non-empty attributes, and instead set/modify res appropriately so
downstream code can append the activationPackage suffix when push_drv is true
(referencing variables/values attribute, res, push_drv, and activationPackage).
In `@src/nixos.rs`:
- Around line 412-415: The warning currently fires when either self.common.dry
is true or variant matches Build|BuildVm, which produces a misleading message
and duplicates the warning already emitted for Build flows; change the condition
so the warn!("--ask has no effect as dry run was requested") is only executed
when self.common.dry && self.common.ask are both true (i.e., only for actual dry
runs), and remove/avoid emitting it for the matches!(variant, Build | BuildVm)
branch to prevent duplication with the existing warning emitted earlier in run.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/commands.rssrc/darwin.rssrc/home.rssrc/interface.rssrc/nixos.rs
💤 Files with no reviewable changes (1)
- src/commands.rs
🚧 Files skipped from review as they are similar to previous changes (1)
- src/interface.rs
Comment on lines
+580
to
+589
| if let Some(store_path) = actual_store_path { | ||
| debug!( | ||
| "Completed {variant:?} operation with store path: {store_path:?}" | ||
| ); | ||
| } else { | ||
| debug!( | ||
| "Completed {variant:?} operation with local output path: \ | ||
| {out_path:?}" | ||
| ); | ||
| } |
There was a problem hiding this comment.
Avoid premature/duplicate “completed” logs in activation flow.
For Switch, the block at Line 580 logs completion before boot activation runs (Line 592+), and then logs completion again at Line 635. This can report success before the operation actually finishes.
Suggested fix
- if let Some(store_path) = actual_store_path {
- debug!(
- "Completed {variant:?} operation with store path: {store_path:?}"
- );
- } else {
- debug!(
- "Completed {variant:?} operation with local output path: \
- {out_path:?}"
- );
- }Also applies to: 635-641
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/nixos.rs` around lines 580 - 589, The premature/duplicate "Completed
{variant:?}" debug logs should be removed from the early branch so completion is
only logged after boot activation finishes; specifically, remove or defer the
debug! calls that print "Completed {variant:?} operation with store path:
{store_path:?}" / "with local output path: {out_path:?}" that occur when
actual_store_path is Some/None and instead emit a single debug! after the
activation/boot path completes (the later completion log around the Switch
activation code). Update the activation flow around the Switch handling to log
once (using the existing completion message) after the boot
activation/activation_result code paths finish to avoid reporting success
prematurely.
Contributor
Author
|
shut up roomba @coderabbitai whoops, my bad, coderabbit is an actual user... Didn't mean to do that. |
|
✅ Actions performedReviews paused. |
|
Tip For best results, initiate chat on the files or code changes.
I've already paused reviews on this PR as requested. Whenever you'd like me to resume reviewing, just let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
general cleanup. commits are pretty isolated, I'd recommend reviewing them individually.
Sanity Checking
nix fmtto format my Nix codecargo fmtto format my Rust codecargo clippyand fixed any new linter warnings.logic
description.
x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.
Summary by CodeRabbit
Refactor
Behavior
Tests