various: expand formatting#688
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds ChangesDeno/TOML Formatter Integration and Applied Cleanups
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| # Markdown formatting | ||
| deno |
There was a problem hiding this comment.
I'm not a big fan of using a js runtime for formatting, but as discussed with @NotAShelf, there are no other good Markdown formatters we're both happy with.
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@flake.nix`:
- Around line 58-59: The comment states "Format Nix with Alejandra" but the
actual command on the following line invokes nixfmt, which is a different
formatter. Update the comment to accurately reflect the tool being used in the
fd command. Change the comment to state "Format Nix with nixfmt" to match the
nixfmt command that is actually being executed.
- Around line 64-65: The Markdown formatter in flake.nix excludes docs/API.md
using the `-E docs/API.md` flag in the fd command, but this file does not exist
in the repository and the Justfile's deno-fmt recipe does not apply this same
exclusion. Remove the `-E docs/API.md` exclusion from the fd command unless this
file is planned to be generated or managed externally, in which case add a
comment explaining the purpose of the exclusion.
In `@Justfile`:
- Line 4: Update CONTRIBUTING.md at lines 91-100 to document the Deno formatting
step that is now included in the check and fix tasks. The `check` recipe in
Justfile includes `deno-check` and the `fix` recipe includes `deno-fmt`, but the
current documentation only lists cargo-based tools. Add documentation for the
`deno fmt` step to the task descriptions so users are aware that Deno formatting
checks are part of the check and fix process.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 647c6f90-b05a-4fef-8ad6-82edcaf6e651
📒 Files selected for processing (8)
.github/ISSUE_TEMPLATE/bug.yml.github/workflows/changelog.yaml.github/workflows/cleanup.yamlCHANGELOG.mdJustfiledocs/README.mdflake.nixshell.nix
💤 Files with no reviewable changes (1)
- .github/workflows/changelog.yaml
dfc85da to
ed992c0
Compare
Sanity Checking
nix fmtto format my Nix codecargo fmtto format my Rust codecargo clippyand fixed any new linter warnings.logic
description.
x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.