Skip to content

Conversation

MattSturgeon
Copy link
Member

WIP PR to begin porting plugins.lsp server-specific options to the new lsp module. Depends on #3783.

Open questions:

  • Do we still want installXyz and xyzPackage options, or just nullable package options?
  • Which options should be ported to lsp and which to plugins.lspconfig?

@sportshead
Copy link
Contributor

IIRC from my previous testing installing hls will cause a version (not sure if its the default nixpkgs one) of ghc to be in the closure, since hls has a dependency on ghc. Therefore I don't think installGhc actually does anything apart from possibly wasting another ~3gb of disk space, since the extra ghc will only be available in nvim (where it isn't needed) anyway.

@sportshead
Copy link
Contributor

Had a quick test and hls works with installGhc = false (using plugins.lsp). I do think packageFallback is much more useful for haskell – hls loves to complain whenever the bundled ghc version is not the exact same as the workspace ghc version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants