feat(cursors): Cursor launch feedback #471
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to assist in implementing declarable launch feedback settings in kde.
Implementation does not match exact behaviours of kde settings app. For example, when selecting the "Bouncing" option for cursor feedback kde will have no settings written to klaunchrc. However this implementation is very explicit and outputs all cursor settings options. Although it differs from kde's implementation, this more explicit version still works.
This is to assist in making the feedback displayed on the icon in the task manager a declerative setting.
HeitorAugustoLN
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Thanks for contributing to plasma-manager! Also please format the code you wrote with nixfmt-rfc-style. I also need to check if the values are working correctly, which I will do later, since I am not using plasma right now, so I will need to set up a vm first, but everything else looks good to me
Now the allowed values are enforced when configuring cursor feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was configuring my kde setup I noticed that the settings for cursor launch feedback seemed to be missing.
I had a go at adding these settings to the cursorType since they are listed under cursors in kde settings, and added configuration to klaunchrc which I believe is the only place these settings have an effect.
I'm quite new to nix so please let me know if it needs any changes or if you need me to refactor this.