Skip to content

Conversation

@khas-amir
Copy link
Contributor

@khas-amir khas-amir commented Oct 4, 2025

#1924


@stylix-automation stylix-automation bot added topic: home-manager Home Manager target topic: modules /modules/ subsystem labels Oct 4, 2025
@khas-amir khas-amir marked this pull request as draft October 5, 2025 17:09
@khas-amir khas-amir marked this pull request as ready for review October 8, 2025 17:45
@khas-amir khas-amir requested a review from trueNAHO October 8, 2025 17:46
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have a testbed for this.

(
{ colors }:
let
colorTheme = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the dark and light themes so different?

@khas-amir khas-amir marked this pull request as draft October 20, 2025 21:37
@stylix-automation stylix-automation bot added topic: testbed Testbed changes topic: flake /flake.nix, /flake.lock, and /flake/ subsystems topic: stylix /stylix/ subsystem labels Oct 27, 2025
@khas-amir khas-amir marked this pull request as ready for review October 28, 2025 10:05
@khas-amir
Copy link
Contributor Author

I don't understand why the checks are failing.

@stylix-automation stylix-automation bot added the status: merge conflict Merge conflict label Oct 28, 2025
@stylix-automation stylix-automation bot removed the status: merge conflict Merge conflict label Oct 30, 2025
@khas-amir khas-amir requested a review from trueNAHO October 31, 2025 22:25
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the checks are failing.

The locally working evaluations are failing in CI for some reason:

2025-11-04T14:39:20.6152550Z building '/nix/store/r3va1pk1gc1wnmn4ajr8f3vbqicxyx8r-dgop-0.1.7.drv'...
2025-11-04T14:39:20.8373284Z error: Nix daemon disconnected unexpectedly (maybe it crashed?)
2025-11-04T14:39:20.8490390Z WARNING:nix_fast_build:build testbed:dankMaterialShell:light exited with 1
[...]
2025-11-04T14:39:46.9992225Z error: Nix daemon disconnected unexpectedly (maybe it crashed?)
2025-11-04T14:39:47.0068660Z WARNING:nix_fast_build:build testbed:dankMaterialShell:dark exited with 1

-- https://github.com/nix-community/stylix/actions/runs/18920823815/job/54477479189?pr=1932

CI is using Nix 2.32.1 and does not seem to run out of space:

2025-11-04T15:01:53.3287684Z Filesystem      Size  Used Avail Use% Mounted on
2025-11-04T15:01:53.3288211Z /dev/root        72G   51G   22G  71% /

-- https://github.com/nix-community/stylix/actions/runs/18920823815/job/54477479189?pr=1932

Let's hope rerunning CI several times magically fixes the problem.

CC: @0xda157, @danth


@khas-amir, please address and potentially resolve previous change requests.

@trueNAHO
Copy link
Member

trueNAHO commented Nov 8, 2025

I don't understand why the checks are failing.

The locally working evaluations are failing in CI for some reason:

2025-11-04T14:39:20.6152550Z building '/nix/store/r3va1pk1gc1wnmn4ajr8f3vbqicxyx8r-dgop-0.1.7.drv'...
2025-11-04T14:39:20.8373284Z error: Nix daemon disconnected unexpectedly (maybe it crashed?)
2025-11-04T14:39:20.8490390Z WARNING:nix_fast_build:build testbed:dankMaterialShell:light exited with 1
[...]
2025-11-04T14:39:46.9992225Z error: Nix daemon disconnected unexpectedly (maybe it crashed?)
2025-11-04T14:39:47.0068660Z WARNING:nix_fast_build:build testbed:dankMaterialShell:dark exited with 1

-- https://github.com/nix-community/stylix/actions/runs/18920823815/job/54477479189?pr=1932

Maybe rebasing this PR on top of #1961 once its CI passes, also resolves this CI failure.

@0xda157
Copy link
Contributor

0xda157 commented Nov 18, 2025

pulling from master again should fix the ci

Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following things have not been addressed yet:

Comment on lines +36 to 40
dankMaterialShell.home-manager.sharedModules = [
inputs.dankMaterialShell.homeModules.dankMaterialShell.default
];

inherit (inputs.spicetify-nix.nixosModules) spicetify;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure #1932 (comment) meant:

Suggested change
dankMaterialShell.home-manager.sharedModules = [
inputs.dankMaterialShell.homeModules.dankMaterialShell.default
];
inherit (inputs.spicetify-nix.nixosModules) spicetify;
inherit (inputs.spicetify-nix.nixosModules) spicetify;
dankMaterialShell.home-manager.sharedModules = [
inputs.dankMaterialShell.homeModules.dankMaterialShell.default
];

@skiletro
Copy link
Contributor

dankmaterialshell has been upstreamed to nixpkgs now, so the flake input is probably no longer necessary, no?

@trueNAHO
Copy link
Member

dankmaterialshell has been upstreamed to nixpkgs now, so the flake input is probably no longer necessary, no?

I suppose you are referring to upstream commit NixOS/nixpkgs@b744e5a ("nixos/dms-greeter: add module"). However, testing the Home Manager module with the upstream flake probably means that we still need it:

diff --git a/modules/dankMaterialShell/testbeds/dankMaterialShell.nix b/modules/dankMaterialShell/testbeds/dankMaterialShell.nix
new file mode 100644
index 000000000..235dff4cb
--- /dev/null
+++ b/modules/dankMaterialShell/testbeds/dankMaterialShell.nix
@@ -0,0 +1,11 @@
+{ lib, ... }:
+{
+  stylix.testbed.ui = {
+    graphicalEnvironment = "hyprland";
+    command.text = "dms run";
+  };
+
+  home-manager.sharedModules = lib.singleton {
+    programs.dankMaterialShell.enable = true;
+  };
+}
diff --git a/stylix/testbed/default.nix b/stylix/testbed/default.nix
index cd43da058..c002f6aeb 100644
--- a/stylix/testbed/default.nix
+++ b/stylix/testbed/default.nix
@@ -33,6 +33,10 @@ let
               )
             )
             {
+              dankMaterialShell.home-manager.sharedModules = [
+                inputs.dankMaterialShell.homeModules.dankMaterialShell.default
+              ];
+
               inherit (inputs.spicetify-nix.nixosModules) spicetify;

               nixvim-integrated = inputs.nixvim.nixosModules.nixvim;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: flake /flake.nix, /flake.lock, and /flake/ subsystems topic: home-manager Home Manager target topic: modules /modules/ subsystem topic: stylix /stylix/ subsystem topic: testbed Testbed changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants