-
-
Notifications
You must be signed in to change notification settings - Fork 300
DankMaterialShell: init target #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 5ab8f90.
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Changes have been tested in testbeds
Would be great to have a testbed for this.
modules/dankMaterialShell/hm.nix
Outdated
| ( | ||
| { colors }: | ||
| let | ||
| colorTheme = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the dark and light themes so different?
Co-authored-by: awwpotato <[email protected]>
|
I don't understand why the checks are failing. |
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why the checks are failing.
The locally working evaluations are failing in CI for some reason:
2025-11-04T14:39:20.6152550Z building '/nix/store/r3va1pk1gc1wnmn4ajr8f3vbqicxyx8r-dgop-0.1.7.drv'... 2025-11-04T14:39:20.8373284Z error: Nix daemon disconnected unexpectedly (maybe it crashed?) 2025-11-04T14:39:20.8490390Z WARNING:nix_fast_build:build testbed:dankMaterialShell:light exited with 1 [...] 2025-11-04T14:39:46.9992225Z error: Nix daemon disconnected unexpectedly (maybe it crashed?) 2025-11-04T14:39:47.0068660Z WARNING:nix_fast_build:build testbed:dankMaterialShell:dark exited with 1-- https://github.com/nix-community/stylix/actions/runs/18920823815/job/54477479189?pr=1932
CI is using Nix 2.32.1 and does not seem to run out of space:
2025-11-04T15:01:53.3287684Z Filesystem Size Used Avail Use% Mounted on 2025-11-04T15:01:53.3288211Z /dev/root 72G 51G 22G 71% /-- https://github.com/nix-community/stylix/actions/runs/18920823815/job/54477479189?pr=1932
Let's hope rerunning CI several times magically fixes the problem.
@khas-amir, please address and potentially resolve previous change requests.
Maybe rebasing this PR on top of #1961 once its CI passes, also resolves this CI failure. |
|
pulling from master again should fix the ci |
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following things have not been addressed yet:
| dankMaterialShell.home-manager.sharedModules = [ | ||
| inputs.dankMaterialShell.homeModules.dankMaterialShell.default | ||
| ]; | ||
|
|
||
| inherit (inputs.spicetify-nix.nixosModules) spicetify; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure #1932 (comment) meant:
| dankMaterialShell.home-manager.sharedModules = [ | |
| inputs.dankMaterialShell.homeModules.dankMaterialShell.default | |
| ]; | |
| inherit (inputs.spicetify-nix.nixosModules) spicetify; | |
| inherit (inputs.spicetify-nix.nixosModules) spicetify; | |
| dankMaterialShell.home-manager.sharedModules = [ | |
| inputs.dankMaterialShell.homeModules.dankMaterialShell.default | |
| ]; |
|
dankmaterialshell has been upstreamed to nixpkgs now, so the flake input is probably no longer necessary, no? |
I suppose you are referring to upstream commit NixOS/nixpkgs@b744e5a ("nixos/dms-greeter: add module"). However, testing the Home Manager module with the upstream flake probably means that we still need it:
|
#1924