Skip to content

Conversation

@Nerglej
Copy link

@Nerglej Nerglej commented Nov 24, 2025

See #1953

I'm very sorry for the scarce documentation for this PR. I'm not that used to submitting PR's like this. I hope someone can correct my errors.


@stylix-automation stylix-automation bot added topic: home-manager Home Manager target topic: modules /modules/ subsystem labels Nov 24, 2025
@Nerglej Nerglej changed the title Add addCss option for swaync feat(swaync): Add addCss option for swaync Nov 24, 2025
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very sorry for the scarce documentation for this PR. I'm not that used to submitting PR's like this. I hope someone can correct my errors.

LGTM, except for one nitpick. For reference, this PR is essentially the same as commit e81bd0c ("waybar: add addCss option (#804)").

I've already made the code (that I would use), but I couldn't get the development project to run correctly with my config, caused by gnome-shell inputs, and then I ran out of time. Therefore I figured this issue would be appropriate instead of a pull request with untested code.

-- #1953

AFAICT, this PR should work. Do you still want to test this PR?

The request-reviewers action fails for the same reason as mentioned in #1931 (comment). Pinging @TheMaxMur, in case you want to take a look at this.

Comment on lines +6 to +12
extraOptions = {
addCss = lib.mkOption {
type = lib.types.bool;
default = true;
description = "adds fully functional css (otherwise just adds colors and fonts)";
};
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick:

Suggested change
extraOptions = {
addCss = lib.mkOption {
type = lib.types.bool;
default = true;
description = "adds fully functional css (otherwise just adds colors and fonts)";
};
};
extraOptions.addCss = lib.mkOption {
type = lib.types.bool;
default = true;
description = "adds fully functional css (otherwise just adds colors and fonts)";
};

@stylix-automation stylix-automation bot added the status: merge conflict Merge conflict label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: merge conflict Merge conflict topic: home-manager Home Manager target topic: modules /modules/ subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants