-
-
Notifications
You must be signed in to change notification settings - Fork 300
doc: styling: add filetypes #2024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will follow up with more PRs to make existing modules compliant.
Thanks a lot for working on this.
The color choices are inspired by base16-vivid, tinted-yazi and some of my old configs. I'd love to see some suggestions.
It is hard to really gauge the quality of these colors without visual validation. If you would apply this style guide to existing modules in this PR in a separate commit, it would be much easier to validate.
6b7db14 to
7072958
Compare
|
I've applied the new rules to the Yazi module. Is there some simple way to make it quickly display a bunch of files that match the theme rules? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've applied the new rules to the Yazi module.
I suppose this is not the only module affected by this.
Is there some simple way to make it quickly display a bunch of files that match the theme rules?
Aside from what commit ceda12a ("flake: add Flake Parts tree into testbed environment (#1642)") provides, there is no further internal setup. If you want to implement that for yazi, do that also in a separate commit.
| extraOptions = { | ||
| boldDirectory = lib.mkOption { | ||
| description = "Whether to use bold font for directories."; | ||
| type = lib.types.bool; | ||
| default = true; | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I only changed Yazi for now to have a visual example of the new guidelines. Once we agree on the colors, I'll implement this for other modules. |
c9360ad to
5f7d47d
Compare
5f7d47d to
d05d2ff
Compare
Styling guidelines for file managers.
The color choices are inspired by base16-vivid, tinted-yazi and some of my old configs. I'd love to see some suggestions.
Will follow up with more PRs to make existing modules compliant.