Skip to content

flake: update all inputs #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trueNAHO merged 1 commit into from
Jan 8, 2026
Merged

flake: update all inputs #2117

trueNAHO merged 1 commit into from
Jan 8, 2026

Conversation

@stylix-automation
Copy link
Contributor

@stylix-automation stylix-automation bot commented Jan 1, 2026 •
edited
Loading

This is an automated update triggered by the workflow run #20724718851.

@stylix-automation stylix-automation bot added topic: dependencies Dependency updates topic: flake /flake.nix, /flake.lock, and /flake/ subsystems status: merge conflict Merge conflict labels Jan 1, 2026
@stylix-automation stylix-automation bot force-pushed the update_flake_lock_action_master branch from e4c8acc to 2ecdb6c Compare January 5, 2026 18:12
@stylix-automation stylix-automation bot added topic: documentation Documentation additions or improvements topic: testbed Testbed changes topic: modules /modules/ subsystem topic: stylix /stylix/ subsystem and removed status: merge conflict Merge conflict labels Jan 5, 2026
@trueNAHO trueNAHO mentioned this pull request Jan 6, 2026
Merged
6 tasks
@trueNAHO
Copy link
Member

trueNAHO commented Jan 6, 2026 •
edited
Loading

Take a look at the previous commits (745f372 to c72f6e4) to see my investigation.

During Git bisection of Nixpkgs, I saw commits other than NixOS/nixpkgs@f19b523 ("mdbook: 0.4.52 -> 0.5.1") that touched relevant mdbook modules. I suppose recent changes to the mdbook-alerts plugin are the real culprit. Before further investigating, maybe someone has an idea what the problem might be.

I saw that NixVim currently has no mdbook-related build failures.

CC: @MattSturgeon

@MattSturgeon
Copy link
Member

MattSturgeon commented Jan 6, 2026 •
edited by trueNAHO
Loading

I saw that NixVim currently has no mdbook-related build failures.

nix-community/nixvim#4135 is also building our mdbook docs ok, although it has plenty of unrelated failures...

We had a failure in December which lead to us dropping mdbook-pagetoc: nix-community/nixvim@8d085d4

I see you're only using:

stylix/doc/default.nix

Lines 660 to 664 in a4406d9

buildInputs = [
mdbook
mdbook-alerts
mdbook-linkcheck
];

Maybe try dropping mdbook-linkcheck? IIRC dropping that one also restructures mdbook's build outputs.

trueNAHO pushed a commit that referenced this pull request Jan 7, 2026
@stylix-automation @trueNAHO
flake: update all inputs
f887798 
Update all inputs and, following upstream commit [2] ("mdbook: 0.4.52 ->
0.5.1"), remove the deprecated and natively supported mdbook-alerts
plugin [1], and the currently broken mdbook-linkcheck plugin [3].

Link: #2117

Co-authored-by: NAHO <[email protected]>

[1]: Michael-F-Bryan/mdbook-linkcheck#96
[2]: NixOS/nixpkgs@f19b523
[3]: lambdalisue/rs-mdbook-alerts@d7a11a0
@trueNAHO trueNAHO force-pushed the update_flake_lock_action_master branch from c72f6e4 to f887798 Compare January 7, 2026 18:32
@trueNAHO
Copy link
Member

trueNAHO commented Jan 7, 2026

I saw that NixVim currently has no mdbook-related build failures.

nix-community/nixvim#4135 is also building our mdbook docs ok, although it has plenty of unrelated failures...

NixVim's mdbook-alerts dependency should also fail on newer Nixpkgs versions. I opened NixOS/nixpkgs#477833 to make the error more instructive.

We had a failure in December which lead to us dropping mdbook-pagetoc: nix-community/nixvim@8d085d4

The recent mdbook 0.5.0 release introduced breaking changes for downstream plugins. Either way, it seems mdbook-pagetoc is also natively supported now:

image

If that is the case, consider opening a PR similar to NixOS/nixpkgs#477833. I would also be fine opening such a PR if you can confirm that mdbook-pagetoc is indeed now natively supported.

Maybe try dropping mdbook-linkcheck? IIRC dropping that one also restructures mdbook's build outputs.

Until Michael-F-Bryan/mdbook-linkcheck#96 is resolved, we are forced to temporarily remove mdbook-linkcheck.

@stylix-automation @trueNAHO
flake: update all inputs
bb34165 
Update all inputs and, following upstream commit [2] ("mdbook: 0.4.52 ->
0.5.1"), remove the deprecated and natively supported mdbook-alerts
plugin [1], and the currently broken mdbook-linkcheck plugin [3].

Link: #2117

Co-authored-by: NAHO <[email protected]>

[1]: Michael-F-Bryan/mdbook-linkcheck#96
[2]: NixOS/nixpkgs@f19b523
[3]: lambdalisue/rs-mdbook-alerts@d7a11a0
@trueNAHO trueNAHO force-pushed the update_flake_lock_action_master branch from f887798 to bb34165 Compare January 7, 2026 19:39
trueNAHO
trueNAHO approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I will merge this to allow progressing #2087 and #2130.

@trueNAHO trueNAHO merged commit a525e47 into master Jan 8, 2026
3 checks passed
@trueNAHO trueNAHO deleted the update_flake_lock_action_master branch January 8, 2026 15:33
@trueNAHO trueNAHO mentioned this pull request Jan 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trueNAHO trueNAHO trueNAHO approved these changes

Assignees

No one assigned

Labels

topic: dependencies Dependency updates topic: documentation Documentation additions or improvements topic: flake /flake.nix, /flake.lock, and /flake/ subsystems topic: modules /modules/ subsystem topic: stylix /stylix/ subsystem topic: testbed Testbed changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trueNAHO @MattSturgeon