Skip to content

Conversation

@trueNAHO
Copy link
Member

commit bbcaeec0a62ad5bd84f950e7c8834f7ab8a89033
Author: NAHO
Date:   2026-01-11 13:27:54 +0100

    stylix/mk-target: add missing comma to function arguments

    Fixes: c4fa684471d9 ("stylix: add mkTarget function")

 stylix/mk-target.nix | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 75e660b6a07af6fc4d1d7aeff6f2f5ddaefc52e5
Author: NAHO
Date:   2026-01-10 21:05:39 +0100

    stylix/mk-target: remove redundant unconditionalConfig argument

    Remove the redundant unconditionalConfig argument to simplify the
    interface, as it is a subset of the existing config argument:

         { mkTarget, ... }:
         mkTarget {
        -  unconditionalConfig =
        +  config = _:
             lib.mkIf complexCondition { home.packages = [ pkgs.hello ]; };
         }

 stylix/mk-target.nix | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

The empty config argument case has been tested by verifying that the arbitrary do_i_exist setting is included in the configuration file of the following testbed:

diff --git a/modules/kitty/hm.nix b/modules/kitty/hm.nix
index e7349475..6361a7fe 100644
--- a/modules/kitty/hm.nix
+++ b/modules/kitty/hm.nix
@@ -12,6 +12,7 @@ mkTarget {
   };

   config = [
+    (_: { programs.kitty.settings.do_i_exist = true; })
     (
       { fonts }:
       {

Fixes: c4fa684 ("stylix: add mkTarget function")
Remove the redundant unconditionalConfig argument to simplify the
interface, as it is a subset of the existing config argument:

     { mkTarget, ... }:
     mkTarget {
    -  unconditionalConfig =
    +  config = _:
         lib.mkIf complexCondition { home.packages = [ pkgs.hello ]; };
     }
@stylix-automation stylix-automation bot added the topic: stylix /stylix/ subsystem label Jan 11, 2026
Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xda157 0xda157 added the backport: release-25.11 To be backported to the release-25.11 stable branch label Jan 12, 2026
@0xda157 0xda157 merged commit 3da76b6 into nix-community:master Jan 12, 2026
5 checks passed
@stylix-automation
Copy link
Contributor

Successfully created backport PR for release-25.11:

@github-actions github-actions bot added the has: port to stable This has been backported to the latest stable branch label Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport: release-25.11 To be backported to the release-25.11 stable branch has: port to stable This has been backported to the latest stable branch topic: stylix /stylix/ subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants