regreet: allow silencing warning caused by using custom session command#2366
Open
abkein wants to merge 1 commit into
Open
regreet: allow silencing warning caused by using custom session command#2366abkein wants to merge 1 commit into
abkein wants to merge 1 commit into
Conversation
The warning is very annoying
0xda157
requested changes
Jun 17, 2026
0xda157
left a comment
Contributor
There was a problem hiding this comment.
thanks for your contributing, i've left some notes inline
| lib.optional | ||
| ( | ||
| cfg.enable | ||
| && (!cfg.disableCustomGreetdWarning) |
Contributor
There was a problem hiding this comment.
the checks are failing because in this scope cfg is referencing the nixos modules's options, not the stylix module's. you'll need to modify this config segment to take { cfg } as an argument and rename the existing cfg. something like this:
config = [
(
{ cfg }:
{
warnings =
let
hmCfg = config.programs.regreet;
in
# ...
Comment on lines
+41
to
+43
| disableCustomGreetdWarning = lib.mkOption { | ||
| description = '' | ||
| Disable warning produced by this module when using custom `services.greetd.settings.default_session.command`. |
Contributor
There was a problem hiding this comment.
maybe an option name that's a little more clear, something like this:
Suggested change
| disableCustomGreetdWarning = lib.mkOption { | |
| description = '' | |
| Disable warning produced by this module when using custom `services.greetd.settings.default_session.command`. | |
| silenceCustomSessionCommandWarning = lib.mkOption { | |
| description = '' | |
| Silences the warning produced by this module when using custom `services.greetd.settings.default_session.command`. |
| ''; | ||
| type = lib.types.bool; | ||
| default = false; | ||
| example = "true"; |
Contributor
There was a problem hiding this comment.
Suggested change
| example = "true"; | |
| example = true; |
| ) | ||
| ) | ||
| "stylix: regreet: custom services.greetd.settings.default_session.command value may not work: ${config.services.greetd.settings.default_session.command}"; | ||
| "stylix: regreet: custom `services.greetd.settings.default_session.command` value may not work: ${config.services.greetd.settings.default_session.command}"; |
Contributor
There was a problem hiding this comment.
could you also mention the option to silence the warning in the warning itself please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning is very annoying