Skip to content

treewide: add accentColor Option - #2404

Open
lwb-2021 wants to merge 43 commits into
nix-community:masterfrom
lwb-2021:master
Open

treewide: add accentColor Option#2404
lwb-2021 wants to merge 43 commits into
nix-community:masterfrom
lwb-2021:master

Conversation

@lwb-2021

@lwb-2021 lwb-2021 commented Jul 6, 2026

Copy link
Copy Markdown

@stylix-automation stylix-automation Bot added topic: home-manager Home Manager target topic: darwin nix-darwin target topic: modules /modules/ subsystem topic: stylix /stylix/ subsystem labels Jul 6, 2026
@lwb-2021
lwb-2021 marked this pull request as draft July 6, 2026 11:19
@lwb-2021
lwb-2021 force-pushed the master branch 4 times, most recently from dcfc29c to dde9228 Compare July 6, 2026 16:19

@trueNAHO trueNAHO left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combining the base16 scheme with an arbitrary subset of a semantic representation introduces subtle breaking changes, further ambiguates the style guide, and undesirably encourages bloating the base16 scheme with unrelated features. I am against this.

Full semantic support is pending in #892 and I will take care of this once I get to it.

@lwb-2021
lwb-2021 marked this pull request as ready for review July 7, 2026 02:07
@lwb-2021

lwb-2021 commented Jul 7, 2026

Copy link
Copy Markdown
Author

How will it support accent color instead of just using blue as accent color or just replacing blue with accent color?

@trueNAHO

trueNAHO commented Jul 7, 2026

Copy link
Copy Markdown
Member

How will it support accent color instead of just using blue as accent color or just replacing blue with accent color?

Could you be more specific? I do not understand.

Why do you only want accent colors?

@lwb-2021

lwb-2021 commented Jul 8, 2026

Copy link
Copy Markdown
Author

How will it support accent color instead of just using blue as accent color or just replacing blue with accent color?

Could you be more specific? I do not understand.

Why do you only want accent colors?

Now we use base0D as blue and accent color, and if we want to change accent color by changing base0D(for example to mavue) we may get mavue where we expect to get blue(for example, in nixos-icons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: merge conflict Merge conflict topic: darwin nix-darwin target topic: home-manager Home Manager target topic: modules /modules/ subsystem topic: stylix /stylix/ subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants