glance: use more appropriate colors for positive and negative - #2480
Open
MrSom3body wants to merge 1 commit into
Open
glance: use more appropriate colors for positive and negative#2480MrSom3body wants to merge 1 commit into
MrSom3body wants to merge 1 commit into
Conversation
stylix-automation
Bot
added
topic: nixos
MrSom3body
force-pushed
the
fix/glance-colors
branch
from
August 15, 2026 18:54
3f186de to
cc34a04
Compare
louis-thevenet
approved these changes
Aug 17, 2026
louis-thevenet
left a comment
louis-thevenet
left a comment
Member
There was a problem hiding this comment.
Yup, it does look better. Thanks for the PR =)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the positive color in Glance is
base01. This leads to things in thepositive color being almost unreadable, as can be seen here:
Moreover, it makes negative colors seem to imply something positive rather bad.
This modifies it such that positive colors are
base08and negative colors arebase0B. The two themes provided upstream as defaults use the primary color as the positive color, but I opted forbase0Bto better reflect the meaning.