zen-browser: fix selection colors after Firefox 154 - #2484
Open
saadndm wants to merge 1 commit into
Open
Conversation
trueNAHO
requested changes
Aug 23, 2026
trueNAHO
left a comment
Member
There was a problem hiding this comment.
The change itself looks good, except for minor things. Thanks for the detailed explanation.
I did not update the testbed's
zen-browserflake because it requiresffmpeg_9which is not in the pinned nixpkgs version.
Unless this causes non-trivial and unrelated issues, consider updating both zen-browser and nixpkgs inputs.
Comment on lines
+71
to
+72
| "ui.highlight" = "#${colors.base0D}"; | ||
| "ui.highlighttext" = "#${colors.base00}"; |
Member
There was a problem hiding this comment.
Could you use the withHashtag variant here? Although /modules/zen-browser/userChrome.nix does not use it either, it might be good to keep at least this file pristine. Polishing /modules/zen-browser/userChrome.nix is out of the scope of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The text selection theming introduced in #2184 and the urlbar text selection highlight no longer works with Firefox 154 after mozilla-firefox/firefox@fe629a3. It now ignores
::selectionfrom user stylesheets, and instead falls back toui.highlightandui.highlighttextpreferences.This PR sets those
ui.highlightandui.highlighttextpreferences tobase0Dandbase00.base02andbase05for webpage selection. After Firefox 154 we can no longer keep webpage selection colors separate from the browser UI selection, and (personally) this new accent pair has better contrast in most cases.::selectionrule is still needed because it overrides selection color defined by websites, but changed it to usebase0Dandbase00for consistency.Note: I did not update the testbed's
zen-browserflake because it requiresffmpeg_9which is not in the pinned nixpkgs version.