wpaperd: fix image scaling modes #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueNAHO
requested changes
Dec 31, 2024
fractalbeauty
force-pushed
the
imagescalingmode-wpaperd
branch
from
321d5f6 to
2828cfb
Compare
trueNAHO
reviewed
Jan 2, 2025
fractalbeauty
force-pushed
the
imagescalingmode-wpaperd
branch
from
2828cfb to
e618356
Compare
trueNAHO
requested changes
Jan 7, 2025
Member
trueNAHO
left a comment
trueNAHO
left a comment
There was a problem hiding this comment.
Can you git rebase master and make sure the CI is passing? You can test the formatters and linters locally with nix build .#checks.x86_64-linux.git-hooks.
fractalbeauty
force-pushed
the
imagescalingmode-wpaperd
branch
from
e618356 to
a149d2f
Compare
Contributor
Author
|
@trueNAHO could you take a look again? |
Contributor
Author
|
Thanks! |
fractalbeauty
added a commit
to fractalbeauty/stylix
that referenced
this pull request
Mar 10, 2025
Previously, the fill image scaling mode in wpaperd was mapped to its fit mode, which scales the image to fit within the screen without cropping. The behavior is now updated to use wpaperd's center mode instead, aligning more closely with swaybg's fill mode. [1] [1]: https://github.com/danyspin97/wpaperd/blob/b0b7e66fd32dca36c431a174784a2e87af7edb77/README.md#wallpaper-configuration Link: nix-community#710 Reviewed-by: NAHO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
fillimage scaling mode would usefitin wpaperd, which scales the image to fit within the screen without cropping it. This PR uses wpaperd'scentermode instead which is closer to swaybg'sfillmode (scales the image to fill the screen, potentially cropping).See https://github.com/danyspin97/wpaperd#wallpaper-configuration