Only use realpath to resolve source paths - #14
Merged
Conversation
Using `realpath` for both the source and destination paths can cause mounts in the sandbox to appear in the wrong location. For example, `--rw /var/run/docker.sock` causes the sandbox to contain `/run/docker.sock` instead of `/var/run/docker.sock`, which prevents Docker from connecting to the host daemon without further configuration. This updates the logic in `bubblebox.js` to only use `realpath` on the source path to ensure that the sandbox contains the mount at the expected location.
Member
|
Hi, and thanks a lot for your contribution! I'll have a look at it soon and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
realpathfor both the source and destination paths can cause mounts in the sandbox to appear in the wrong location.For example,
--rw /var/run/docker.sockcauses the sandbox to contain/run/docker.sockinstead of/var/run/docker.sock, which prevents Docker from connecting to the host daemon without further configuration.This updates the logic in
bubblebox.jsto only userealpathon the source path to ensure that the sandbox contains the mount at the expected location.