Skip to content

Update to Include RD/AD workaround and various other changes/fixes #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

bbviking
Copy link

@bbviking bbviking commented Nov 25, 2024

Apologies, this is my second time creating this pull request. Created it earlier, but in my attempt to clean up the messy commit history ended up breaking it, so i recreated the fork.

Changes:

  • Version bump to 3.0.5
  • Included RD fix by henryjfry (modified to only check if hash is cached when attempting to play source, similar to Tikipeter implementation, resulting in much faster scrape times and reduced RD API calls)
  • Added option to filter results by internet speed instead of just file size
  • Added 'Minimum Percentage Left Before Showing Dialog option' for smartplay window. Whichever one occurs first (percent or time remaining) will be used to dictate when the window will be shown
  • Added 'Cancel' button to smartplay window
  • Added option to hide resolver window when attempting to play
  • Added 'Icon Only' scraper display style option for a more minimalistic background scrape
  • Improved 3D filtering and added 60 FPS filter

@bbviking
Copy link
Author

Updated to also fix All Debrid

@bbviking bbviking changed the title Update to Include RD workaround and various other changes/fixes Update to Include RD/AD workaround and various other changes/fixes Nov 27, 2024
@henryjfry
Copy link

henryjfry commented Dec 9, 2024

bbviking you might want to have a look at my other PR here:

#955

Or more specifically my commit here:

henryjfry@2c091e7

There are further issues with the RD cloud scrape which havent yet been fixed which i think ive achieved.
Also possibly a fix for the trakt crash issue, if you dont use trakt within seren.

So i did try to raise it as a PR on your fork rather than the main branch but i obviously did it wrong.
There are also a tonne of changes which are just tabs/spaces (which i did because i always changes spaces to tabs and i wanted to see only the modifications once i copied over my modified files).

So you (or whoever) is in a position to approve/reject PR's may want to just apply my couple of fixes here and there and reject the actual PR?

Im not sure that mine doesnt revert some fixes on yours?

@Atroxit
Copy link

Atroxit commented Dec 16, 2024

Any timeline on when this will get merged? @drinfernoo

@JKelly423
Copy link

Cloning this branch and trying to install locally results in an error installing addon

@henryjfry
Copy link

henryjfry commented Feb 23, 2025

Cloning this branch and trying to install locally results in an error installing addon

Probably a bunch of dependency errors from whatever repo it was originally hosted on.

I think Kodi now will, even if you have a repo setup which hosts whatever dependencies you need they won't be installed unless they are on the same repo your addon is on.
So you are better of installing an old or different version from a repo and then installing the update manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants