ci: fix Windows test glob + Ubuntu mysql/mariadb apt conflict

Two CI failures from PR #4:
- Windows: ./internal/driver/_*/ is a bash glob PowerShell doesn't expand, so
  go test got a literal path and failed. Name _mysqlcommon by import path
  instead (portable across shells); mirror in the Makefile.
- Ubuntu: mariadb-client Conflicts with mysql-client-core, so they can't
  co-install. Install mysql-client from Ubuntu and pull mariadb-client from
  MariaDB's official APT repo, which is built to coexist.

Author: nixrajput

.github/workflows/ci.yml

@@ -38,10 +38,11 @@ jobs:
           cache: true
       - name: go vet
         run: go vet ./...
-      # `./...` skips underscore-prefixed dirs, so name _*-prefixed packages
-      # explicitly (e.g. internal/driver/_mysqlcommon) to run their unit tests.
+      # `./...` skips underscore-prefixed dirs, so name the _mysqlcommon package
+      # explicitly by import path to run its unit tests. Use the import path (not
+      # a `_*` shell glob) so it works on PowerShell (Windows) as well as bash.
       - name: go test
-        run: go test ./... ./internal/driver/_*/
+        run: go test ./... github.com/nixrajput/siphon/internal/driver/_mysqlcommon
       # Integration tests use testcontainers, which needs a Docker daemon.
       # Only ubuntu-latest runners have Docker available by default, so the
       # DB client install and integration suite are scoped to Ubuntu.
@@ -51,14 +52,14 @@ jobs:
         if: matrix.os == 'ubuntu-latest'
         run: |
           sudo apt-get update
-          # postgresql-client -> pg_dump/pg_restore
-          # mysql-client      -> mysqldump/mysql
-          # mariadb-client    -> mariadb-dump/mariadb
-          # NOTE: mysql-client and mariadb-client can conflict on some Ubuntu
-          # releases (both provide the mysql* binaries via alternatives). If apt
-          # reports a conflict in CI, split them or drop mysql-client (mariadb-client
-          # provides mysql-compatible binaries) as a one-line follow-up.
-          sudo apt-get install -y postgresql-client mysql-client mariadb-client
+          # postgresql-client -> pg_dump/pg_restore ; mysql-client -> mysqldump/mysql
+          sudo apt-get install -y postgresql-client mysql-client
+          # Ubuntu's mariadb-client Conflicts with mysql-client-core, so it can't
+          # co-install. Pull mariadb-dump/mariadb from MariaDB's official APT repo
+          # (the repo's mariadb-client is built to coexist with MySQL's client).
+          curl -fsSL https://r.mariadb.com/downloads/mariadb_repo_setup | sudo bash
+          sudo apt-get update
+          sudo apt-get install -y mariadb-client
       - name: Integration tests (Ubuntu only — needs Docker)
         if: matrix.os == 'ubuntu-latest'
-        run: go test -tags=integration ./... ./internal/driver/_*/
+        run: go test -tags=integration ./... github.com/nixrajput/siphon/internal/driver/_mysqlcommon

Makefile

@@ -11,17 +11,19 @@ lint: ## Run golangci-lint
 
 # NOTE: `go test ./...` skips directories whose names start with `_` (Go tool
 # convention), so underscore-prefixed packages with real tests (e.g.
-# internal/driver/_mysqlcommon) are silently excluded. Name them explicitly via
-# the `_*` glob so their unit tests actually run. The glob auto-picks up any
-# future _*-prefixed package under internal/driver/.
+# internal/driver/_mysqlcommon) are silently excluded. Name them explicitly by
+# import path so their unit tests run. Use the import path (not a `_*` shell
+# glob) so this is identical to what CI runs and works regardless of shell.
+UNDERSCORE_PKGS := github.com/nixrajput/siphon/internal/driver/_mysqlcommon
+
 test: ## Run unit tests
-	go test ./... ./internal/driver/_*/
+	go test ./... $(UNDERSCORE_PKGS)
 
 test-verbose: ## Run unit tests verbosely
-	go test -v ./... ./internal/driver/_*/
+	go test -v ./... $(UNDERSCORE_PKGS)
 
 test-integration: ## Run integration tests (build tag: integration)
-	go test -tags=integration ./... ./internal/driver/_*/
+	go test -tags=integration ./... $(UNDERSCORE_PKGS)
 
 build: ## Build the siphon binary into ./bin
 	@mkdir -p bin