-
-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/implement phase e #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
695fd32
feat(driver/_mysqlcommon): shared DSN/args/version/conn helpers
nixrajput 9080ba4
feat(driver/_mysqlcommon): shared Conn implementing driver.Conn for b…
nixrajput 10def93
feat(driver/mysql): MySQL driver via shared mysqlcommon.Conn
nixrajput f2b80da
feat(driver/mariadb): MariaDB driver via shared mysqlcommon.Conn
nixrajput 7b2d3e6
test(driver/mysql): integration suite via RunDriverSuite harness
nixrajput c4ca221
test(driver/mariadb): integration suite via RunDriverSuite harness
nixrajput 51537ba
feat(app): register mysql + mariadb drivers via side-effect import
nixrajput c67848b
ci: install DB clients and run integration suite on Ubuntu
nixrajput 9559175
docs: mark Phase E (MySQL + MariaDB) complete in README, CHANGELOG, D…
nixrajput 8caf1f4
test: run _mysqlcommon unit tests in make + CI; note MariaDB binary r…
nixrajput c20d1b0
ci: fix Windows test glob + Ubuntu mysql/mariadb apt conflict
nixrajput 7a3e134
test(driver): make cancel-propagation subtest engine-agnostic
nixrajput 7801d5d
fix(driver/_mysqlcommon): propagate SSLMode to dump/restore, canonica…
nixrajput f68e95e
revert: drop --ssl-mode from dump/restore args (not portable across f…
nixrajput File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| package mysqlcommon | ||
|
|
||
| import ( | ||
| "strconv" | ||
|
|
||
| "github.com/nixrajput/siphon/internal/driver" | ||
| ) | ||
|
|
||
| // BuildDumpArgs assembles the mysqldump argument vector for a backup. The | ||
| // binary name itself is supplied by the caller (mysqldump vs mariadb-dump). | ||
| func BuildDumpArgs(p driver.Profile, opt driver.BackupOpts) []string { | ||
| args := []string{ | ||
| "-h", p.Host, | ||
| "-P", strconv.Itoa(p.Port), | ||
| "-u", p.User, | ||
| "--single-transaction", | ||
| "--routines", | ||
| "--triggers", | ||
| "--events", | ||
| "--no-tablespaces", | ||
| "--skip-comments", | ||
| p.Database, | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| if opt.SchemaOnly { | ||
| args = append(args, "--no-data") | ||
| } | ||
| if opt.DataOnly { | ||
| args = append(args, "--no-create-info") | ||
| } | ||
| args = append(args, opt.IncludeTables...) | ||
| for _, t := range opt.ExcludeTables { | ||
| args = append(args, "--ignore-table="+p.Database+"."+t) | ||
| } | ||
| return args | ||
| } | ||
|
|
||
| // BuildRestoreArgs assembles the mysql client argument vector for a restore. | ||
| // The dump file is authoritative for shape; the restore client just pipes it | ||
| // in. Clean is a no-op here because mysqldump output already emits | ||
| // DROP TABLE IF EXISTS / CREATE TABLE, making the restore idempotent. | ||
| func BuildRestoreArgs(p driver.Profile, _ driver.RestoreOpts) []string { | ||
| return []string{ | ||
| "-h", p.Host, | ||
| "-P", strconv.Itoa(p.Port), | ||
| "-u", p.User, | ||
| "--default-character-set=utf8mb4", | ||
| p.Database, | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.