feat: add group picker (C-p) to rename dialog#322
Closed
hansonkim wants to merge 1 commit intonjbrake:mainfrom
Closed
feat: add group picker (C-p) to rename dialog#322hansonkim wants to merge 1 commit intonjbrake:mainfrom
hansonkim wants to merge 1 commit intonjbrake:mainfrom
Conversation
The rename dialog bottom hint line showed "C-p groups" on all fields, but Ctrl+P only works on the group field (focused_field == 1). Add the same focused_field guard already used in handle_key and group_hint rendering so the hint matches the actual behavior.
hansonkim
changed the title
Contributor
Author
|
Closing to recreate with correct branch prefix (fix/ → feature/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a group picker to the rename dialog, activated with Ctrl+P when the group field is focused. Shows existing groups in a list picker overlay for quick selection instead of manual typing.
The
C-p groupskeyboard hint is shown only when the group field is focused (focused_field == 1), matching the actual Ctrl+P behavior.Changes
src/tui/dialogs/rename.rs- Addexisting_groupsandListPickertoRenameDialog, handle Ctrl+P key event on group field, render group picker overlay, show contextual hints only when relevantsrc/tui/home/input.rs- Collect existing groups fromgroup_treeand pass toRenameDialog::new()PR Type
Checklist
Test Results
cargo test --lib -- tui::dialogs::rename- 36 tests pass (10 new tests for group picker)cargo clippy -- -D warnings- no warningscargo fmt -- --check- cleanAI Usage
AI Model/Tool used: Claude Code (claude-opus-4-6)
Any Additional AI Details you'd like to share: Consensus code review validated by Gemini (gemini-2.5-pro) and Qwen3 (8B) - both APPROVE with HIGH confidence.