fix: validate project path exists before creating session#327
Merged
njbrake merged 1 commit intonjbrake:mainfrom Feb 26, 2026
Merged
fix: validate project path exists before creating session#327njbrake merged 1 commit intonjbrake:mainfrom
njbrake merged 1 commit intonjbrake:mainfrom
Conversation
When a non-existent path was entered in the TUI new session dialog, `canonicalize()` failed silently and the raw path string was passed to tmux. tmux then fell back to the home directory without any error, causing the session to start in an unexpected location. Add path existence and directory validation in `build_instance()` after worktree resolution, so the TUI displays a clear error message instead of silently creating a session in the wrong directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a non-existent path (e.g.
/Users/hanson/aiworks/abc) was entered in the TUI new session dialog, the session silently started in the home directory instead of showing an error.Root cause:
canonicalize()failure inbuilder.rsfell back to the raw path string, which tmux accepted but silently resolved to$HOME.Added path existence and directory validation in
build_instance()after worktree resolution, leveraging the existingset_error()UI to display a clear error message.PR Type
Checklist
AI Usage
AI Model/Tool used: Claude Code (Opus 4.6)
Any Additional AI Details you'd like to share: Bug investigation and fix implementation assisted by AI.