Skip to content

fix: separate session title from branch#943

Merged
njbrake merged 4 commits intomainfrom
fix/separate-session-title-and-branch
May 7, 2026
Merged

fix: separate session title from branch#943
njbrake merged 4 commits intomainfrom
fix/separate-session-title-and-branch

Conversation

@njbrake
Copy link
Copy Markdown
Owner

@njbrake njbrake commented May 6, 2026

Description

Verification:

  • cd web && npm run build
  • cargo check --features serve
  • cargo test --features serve --lib "server::api::sessions::tests::rename_updates_title_without_changing_worktree_branch" -- --exact
  • cargo test --features serve --lib "server::api::sessions::tests::session_response_branch_from_worktree" -- --exact

PR Type

  • New Feature
  • Bug Fix
  • Refactor
  • Documentation
  • Infrastructure / CI

Checklist

  • I understand the code I am submitting
  • New and existing tests pass
  • Documentation was updated where necessary
  • For UI changes: included screenshot or recording

AI Usage

  • No AI was used
  • AI was used for drafting/refactoring
  • This is fully AI-generated

AI Model/Tool used:
Codex (GPT-5)

Any Additional AI Details you would like to share:
Implemented the web title/branch split and rename metadata fix directly from issue triage for #931.

  • I am an AI Agent filling out this form (check box if true)

@Seluj78
Copy link
Copy Markdown

Seluj78 commented May 7, 2026

Ok so testing this PR locally, I've got a small gripe with it. When clicking on either of the Auto Generated fields I would expect a text box where I can override, but instead I get sent to the session wizard where I need to go to advanced settings, which isn't great UX in my opinion :)

Screenshot 2026-05-07 at 07 44 09

- Sidebar rename now compares against current title rather than the
  displayed label, so accepting the prefilled value when a session has
  no title actually commits the rename.
- Title and Branch rows on the wizard's Review step are inline-editable
  (click to edit, Enter to commit, Escape to cancel). Enter inside the
  editor calls stopPropagation so the window-level submit handler does
  not race with the in-flight state update.
- Sidebar filter matches workspace branch substring again, restoring
  search-by-branch behaviour that was lost when displayName started
  preferring the session title for single-session workspaces.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@njbrake njbrake merged commit 96671cc into main May 7, 2026
@njbrake njbrake deleted the fix/separate-session-title-and-branch branch May 7, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renaming session doesn't rename branch and pushes to a random named branch by default

2 participants