Added client support for self signed certificate on MQTT server#234
Open
Sjd-Risca wants to merge 1 commit into
Open
Added client support for self signed certificate on MQTT server#234Sjd-Risca wants to merge 1 commit into
Sjd-Risca wants to merge 1 commit into
Conversation
|
Nice! Can you think of a unit test for this feature? Maybe creating a tempfile and a certificate and loading that? I mean your changes use external logic, thus nothing should go wrong here. But it comes very handy when adding functionality. |
15 tasks
Contributor
|
Hi @Sjd-Risca hbmqtt has been deprecated by it's author. We created a fork here: https://github.com/Yakifo/amqtt I like this change and would like to include it in our fork. Would you be interested to create your MR there as well? Thanks :) |
Contributor
|
@HerrMuellerluedenscheid would you be interested in carrying this forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to use the mqtt client against a server with a self signed Certificate Authority. The proposed patch will add a new client configuration attribute defined as ca_certs for assigning a custom CA (instead of using the system ones) to the ssl context. The connection will be initiated only if the mqtt server's certificate chain resolved to any of the custom CAs.
For reference, see the implementation from patho-mqtt: https://github.com/eclipse/paho.mqtt.python/blob/225ab3757f6818ba85eb80564948d1c787190cba/src/paho/mqtt/client.py#L767