fix: isolate malformed metadata source failures - #120
Merged
njzjz merged 3 commits intoAug 16, 2026
Conversation
Treat transport, parsing, and malformed-source-data failures as per-source misses while leaving unexpected programming errors visible on native Python. Agent: ChatGPT Model: GPT-5.6 Sol
Verify malformed source payloads are isolated in sync and async DOI aggregation while programming errors still escape. Agent: ChatGPT Model: GPT-5.6 Sol
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
==========================================
- Coverage 94.41% 94.21% -0.20%
==========================================
Files 15 15
Lines 949 951 +2
==========================================
Hits 896 896
- Misses 53 55 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
njzjz
approved these changes
Aug 16, 2026
njzjz
marked this pull request as ready for review
August 16, 2026 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeErrorRoot cause
The source wrappers only isolated transport errors on native Python. Common upstream payload failures such as missing keys, invalid JSON-derived values, and malformed XML could therefore propagate through
future.result()/asyncio.gather()and discard otherwise usable results.Validation
Added focused coverage in
tests/test_source_error_isolation.py. Full repository CI should run on this PR.Fixes #114
Agent: ChatGPT
Model: GPT-5.6 Sol