Skip to content

Fix loading the proper home-$posttype.php file and fix phpunit #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
losted wants to merge 2 commits into from
Closed

Fix loading the proper home-$posttype.php file and fix phpunit #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89fb058
[FIX] Adding .php at the end of home-$posttype path so that if find t…
libeo-luc Mar 20, 2026
781ca96
[FIX] Tests
libeo-luc Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
>
<testsuites>
<testsuite name="integrtion">
<directory prefix="test-" suffix=".php">./tests/integration</directory>
<directory>./tests/integration</directory>
</testsuite>
</testsuites>
</phpunit>
2 changes: 1 addition & 1 deletion src/plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ public function set_home_template_hierarchy(array $templates): array
return $templates;
}
return \array_merge([
"home-{$GLOBALS['wp_query']->{self::QUERY_VAR_IS_PFCPT}}",
"home-{$GLOBALS['wp_query']->{self::QUERY_VAR_IS_PFCPT}}.php",
], $templates);
}

Expand Down
4 changes: 2 additions & 2 deletions ...ration/test-page-for-custom-post-type.php → ...integration/PageForCustomPostTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use n5s\PageForCustomPostType\Plugin;
use Yoast\WP\SEO\Memoizers\Meta_Tags_Context_Memoizer;

class TestPageForCustomPostType extends Testkit_Test_Case
class PageForCustomPostTypeTest extends Testkit_Test_Case
{
private string $home_for_book_title = 'Home for Books';

Expand Down Expand Up @@ -62,7 +62,7 @@ public function test_query()
$hierarchy = new Hierarchy();
$this->assertEquals([
'home' => [
"home-{$this->book_post_type}",
"home-{$this->book_post_type}.php",
'home',
'index',
],
Expand Down