anntoconll : fix word with accents being split by tokenization #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marny30
changed the title
Marny30
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version, the anntoconll tool will split a word containing accents into different tokens, isolating the accents as if they were words. When working with european languages such as French, Spanish, etc or even German with the ß this comes to be a problem.
For example, the text "déjà fait" would be split into tokens "d", "é", "j", "à", "fait" instead of "déjà", "fait"
By adding all accents range À-ÿ to the tokenization regex, this tokenization issue doesn't happen anymore.