Skip to content

Simplify boolean conversion #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Simplify boolean conversion #395

merged 3 commits into from
Mar 19, 2025

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Mar 19, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

Introduces the things @sebbi08 did in nmshd/typescript-rest#2, and hands over the job to do the conversion to typescript-rest.

@jkoenig134 jkoenig134 added the refactoring Refactoring of code label Mar 19, 2025
@jkoenig134 jkoenig134 merged commit a41a53f into main Mar 19, 2025
10 checks passed
@jkoenig134 jkoenig134 deleted the simplify-boolean-conversion branch March 19, 2025 10:06
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...es/coreHttpApi/controllers/AttributesController.ts 95.74% <100.00%> (-0.50%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants