Skip to content

Pagination of Messages #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Pagination of Messages #447

wants to merge 10 commits into from

Conversation

Magnus-Kuhn
Copy link
Contributor

@Magnus-Kuhn Magnus-Kuhn commented Mar 5, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

A first bare-bones implementation using the existing docdb-database-abstractions pagination without a default or restrictions for the requested pagination.

A bug is that count(query: {}) on lokijs always returns 0, we run into this because the querytranslator translates an undefined query to {}.

@Magnus-Kuhn Magnus-Kuhn added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...src/extensibility/facades/AppRelationshipFacade.ts 71.79% <100.00%> (+0.54%) ⬆️
...ransport/src/modules/messages/MessageController.ts 88.07% <100.00%> (+0.28%) ⬆️
...ansport/src/modules/sync/SynchronizedCollection.ts 35.24% <100.00%> (ø)
...rt/src/modules/sync/migrations/DeviceMigrations.ts 100.00% <100.00%> (ø)

... and 355 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Magnus-Kuhn Magnus-Kuhn changed the base branch from main to release/v7 March 6, 2025 07:42
@Magnus-Kuhn Magnus-Kuhn added the breaking-change A breaking change label Mar 6, 2025
@jkoenig134
Copy link
Member

@Magnus-Kuhn why is this a breaking change?

@Magnus-Kuhn
Copy link
Contributor Author

The total number of messages is returned as well in the use case as {messages: MessageDTO[], messageCount: number}.

@jkoenig134
Copy link
Member

The total number of messages is returned as well in the use case as {messages: MessageDTO[], messageCount: number}.

IMO no real reason. We can keep the connector api the same and we can update the App accordingly.

@Magnus-Kuhn Magnus-Kuhn removed the breaking-change A breaking change label Mar 6, 2025
@Magnus-Kuhn Magnus-Kuhn changed the base branch from release/v7 to main March 6, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wip Work in Progress (blocks mergify from auto update the branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants