Skip to content

Rework Attributes#662

Merged
jkoenig134 merged 93 commits intorelease/v7from
rework-attributes
Oct 23, 2025
Merged

Rework Attributes#662
jkoenig134 merged 93 commits intorelease/v7from
rework-attributes

Conversation

@jkoenig134
Copy link
Contributor

@jkoenig134 jkoenig134 commented Jul 11, 2025

Warning

This PR is a collection of other PRs and should not be squash merged to make sure that we don't lose the individual commits.

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

This PR is work in progress and missing some key parts to not remove attribute features without adding alternatives.

* chore: remove error

* wip: update AttributeController

* feat: remove parents and childs

* chore: remove unused error

* refactor: variable name

* chore: remove unnessecary tests

---------

Co-authored-by: Milena Czierlinski <milena.czierlinski@js-soft.com>
@jkoenig134 jkoenig134 added the breaking-change A breaking change label Jul 11, 2025
jkoenig134 and others added 28 commits July 11, 2025 09:51
* feat: update imports

* feat: update usable attribute value types

* chore: update schemas

* chore: remove old tests

* chore: update schema

* chore: update tests

* chore: update schemas

* fix: AttributesController tests

* fix: RepositoryAttributeDVO test

* fix: attributes tests

* fix: attributes tests

* fix: last test

* fix: uncomment tests

* fix: update all conversions

* fix: make complex test complex again

* chore: re-add complex test
* refactor: AttributesController

* refactor: more formatting

* chore: rebuild schemas
mergify bot and others added 9 commits September 21, 2025 07:46
* rename: DeletedByEmitter and -Recipient

* chore: delete ThirdPartyRelationshipAttributeDeletionInfo

* chore: renaming

* refactor: rename setPeerDeletionInfoOfReceivedAttribute

* refactor: rename setPeerDeletionInfoOfReceivedAttributeAndPredecessors and simplify code

* refactor: simplify more code of AttributesController

* test: adjust deletionstatuses

* test: expect correct deletion status

* refactor: use AbstractAttributeDeletionInfoJSON in AbstractAttributeSharingDetailsJSON

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…770)

* feat: notify peers who only received a predecessor of the deleted attribute

* test: notification about deleted predecessor

* feat: return early if there are not peers to notify

* test: adjust error message

* test: getPeersWithExclusivelyForwardedPredecessors

* test: adjust error message again
@jkoenig134 jkoenig134 marked this pull request as ready for review September 24, 2025 12:19
@jkoenig134 jkoenig134 requested a review from britsta October 23, 2025 09:19
* chore: add attributeId to ForwardedSharingDetails

* chore: fix error for now

* feat: update code

* test: start updateing consumption tests

* refactor: ForwardedSharingDetails -> ForwardingDetails

* fix: compiler errors in consumption tests

* chore: wording

* chore: remove more query options

* chore: use updateNumberOfForwards everywhere

* fix: hand attributeId to validateFullAttributeDeletionProcess

* fix: only parse attribute if needed and then omit numberOfForwards in comparison

* test: add await

* fix: omit numberOfForwards in more comparisons

* test: expect correct number of forwards

* refactor: use let

* chore: reformat

* refactor: remove unnecessary database calls

* chore: update tests

* chore: remove more filters

* feat: add usecase for getting forwarding details

* refactor: uniform naming

* test: update testUtil

* test: update runtime tests

* fix: update schemas

* feat: add method to query local attributes exchanged with peer

* chore: add new filter

* fix: properly sync ForwardingDetails

* fix: test

* fix: test

* fix: all tests

* chore: build schemas

* fix: toBe

* fix: correct services

* chore: update comment

* fix: not only delete IdentityAttributes

* wording

* chore: remove more useless code

* chore: docs

* chore: inline attribute ids

* chore: remove test

* chore: get rid oftoStrictEqualExcluding in runtime tests

* chore: rename stuff and put it in own files

* refactor: move and rename ForwardingDetails to AttributeForwardingDetails

* refactor: remove hasDeletionStatusUnequalDeletedByRecipient and make getForwardingDetailsForRecipient usable

* feat: add queries to GetForwardingDetailsForAttributeUseCase

* refactor: naming & inlining

* fix: compiler issues

* refactor: move numberOfForwards to ForwardableAttributes

* chore: re-add expect

* fix: update atType

* Update packages/runtime/src/useCases/transport/relationships/GetAttributesForRelationship.ts

Co-authored-by: Milena Czierlinski <146972016+Milena-Czierlinski@users.noreply.github.com>

* chore: updateNumerOfForwards

* refactor: better query

* chore: prettier

* refactor: make forwardingPeers IdentityDVOs

* test: update runtime tests

* chore: remove minNumberOfForwards filter

* chore: remove

* chore: update lockfile

* chore: naming

* chore: naming

* refactor: extract to method

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Milena Czierlinski <milena.czierlinski@js-soft.com>
Co-authored-by: Milena Czierlinski <146972016+Milena-Czierlinski@users.noreply.github.com>
@jkoenig134 jkoenig134 enabled auto-merge (rebase) October 23, 2025 09:34
auto-merge was automatically disabled October 23, 2025 09:43

Rebase failed

@jkoenig134 jkoenig134 merged commit 0d3747b into release/v7 Oct 23, 2025
15 checks passed
@jkoenig134 jkoenig134 deleted the rework-attributes branch October 23, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change A breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants