Extract ForwardedSharingDetails to own collection#777
Merged
jkoenig134 merged 69 commits intorework-attributesfrom Oct 23, 2025
Merged
Extract ForwardedSharingDetails to own collection#777jkoenig134 merged 69 commits intorework-attributesfrom
jkoenig134 merged 69 commits intorework-attributesfrom
Conversation
…-to-own-collection
…-to-own-collection
…-to-own-collection
…-to-own-collection
…-to-own-collection
…-to-own-collection
Member
Milena-Czierlinski
left a comment
Milena-Czierlinski
left a comment
There was a problem hiding this comment.
Looks overall good to me, so feel free to continue.
I know the naming isn't final yet, just wanted to already mention that now that we also flattened the peerSharingDetails, I think we can simplify forwardedSharingDetails e.g. to only forwardedDetails/forwardingDetails. "forwarded" and "sharing" sounds somewhat doppelt-gemoppelt.
...ges/consumption/src/modules/requests/itemProcessors/utility/createAppropriateResponseItem.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
britsta
reviewed
Oct 17, 2025
packages/runtime/src/useCases/consumption/attributes/GetAttributes.ts
Outdated
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Show resolved
Hide resolved
packages/runtime/src/useCases/consumption/attributes/GetAttributes.ts
Outdated
Show resolved
Hide resolved
...Processors/attributeDeleted/ForwardedAttributeDeletedByPeerNotificationItemProcessor.test.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/local/attributeTypes/LocalAttribute.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/local/attributeTypes/LocalAttribute.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/local/attributeTypes/LocalAttribute.ts
Outdated
Show resolved
Hide resolved
…-to-own-collection
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/runtime/src/useCases/consumption/attributes/GetAttributes.ts
Outdated
Show resolved
Hide resolved
packages/runtime/src/useCases/transport/relationships/GetAttributesForRelationship.ts
Outdated
Show resolved
Hide resolved
…butesForRelationship.ts Co-authored-by: Milena Czierlinski <146972016+Milena-Czierlinski@users.noreply.github.com>
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
britsta
requested changes
Oct 23, 2025
...Processors/attributeDeleted/ForwardedAttributeDeletedByPeerNotificationItemProcessor.test.ts
Outdated
Show resolved
Hide resolved
Milena-Czierlinski
approved these changes
Oct 23, 2025
britsta
approved these changes
Oct 23, 2025
jkoenig134
deleted the
extract-ForwardedSharingDetails-to-own-collection
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description