Skip to content

Comments

Add EUDIPLO tests#831

Merged
tnotheis merged 47 commits intorelease/openid4vcfrom
add-eudiplo-tests
Nov 18, 2025
Merged

Add EUDIPLO tests#831
tnotheis merged 47 commits intorelease/openid4vcfrom
add-eudiplo-tests

Conversation

@tnotheis
Copy link
Member

@tnotheis tnotheis commented Nov 6, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@tnotheis tnotheis self-assigned this Nov 6, 2025
@tnotheis tnotheis added the test This pull request contains only new or changed tests label Nov 6, 2025
@tnotheis tnotheis assigned Magnus-Kuhn and unassigned tnotheis Nov 6, 2025
@Magnus-Kuhn Magnus-Kuhn marked this pull request as ready for review November 13, 2025 13:57
jkoenig134
jkoenig134 previously approved these changes Nov 17, 2025
Copy link
Contributor

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We have to remember to update the paches in the app & connector when releasing this.

@tnotheis
Copy link
Member Author

  1. Why would we release this? These are only tests.
  2. The approval was unnecessary. :) We have to wait for the vulnerability to be "fixed" in main before we can merge this PR.

Magnus-Kuhn
Magnus-Kuhn previously approved these changes Nov 17, 2025
Copy link
Contributor

@Magnus-Kuhn Magnus-Kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest credo release fixed the wrong file extensions but also changed the data model, so I'm not bumping it here

@Magnus-Kuhn Magnus-Kuhn dismissed stale reviews from jkoenig134 and themself via 2c25806 November 17, 2025 13:10
@tnotheis tnotheis enabled auto-merge (squash) November 17, 2025 13:12
@tnotheis tnotheis merged commit 1a31c1c into release/openid4vc Nov 18, 2025
24 of 25 checks passed
@tnotheis tnotheis deleted the add-eudiplo-tests branch November 18, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test This pull request contains only new or changed tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants