[vivante] Add json based initialization #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
anyj0527
commented
Jun 10, 2025
anyj0527
commented
- Without .so file to intialize the given model, this supports json based initialization.
- Fix README.md accordingly.
- Without .so file to intialize the given model, this supports json based initialization. - Fix README.md accordingly. Signed-off-by: Yongjoo Ahn <[email protected]>
- Refactor and fix memory leaks Signed-off-by: Yongjoo Ahn <[email protected]>
anyj0527
force-pushed
the
vivante-support-json-info
branch
from
e19c6c8 to
cf1cd9d
Compare
again4you
approved these changes
Jun 10, 2025
- Get dtype values only when they are explictly given. Signed-off-by: Yongjoo Ahn <[email protected]>
- `_NNS_FLOAT16` is always available. Use it. Signed-off-by: Yongjoo Ahn <[email protected]>
abhajaswal
approved these changes
Jun 11, 2025
|
@anyj0527 With acknowledgment from users, you may proceed. |
myungjoo
approved these changes
Jun 11, 2025
|
Thanks alot for your efforts, I have confirmed the changes work well on Tizen 10.0 image for FHUb A311D I have approved the PR. |
|
@abhajaswal Thanks for your thorough review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.