-
Notifications
You must be signed in to change notification settings - Fork 94
Meson option build fixes #2962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meson option build fixes #2962
Conversation
4b4131a to
129daaf
Compare
| endif | ||
|
|
||
| if get_option('platform') != 'android' and host_machine.system() != 'windows' | ||
| if get_option('platform') != 'android' and host_machine.system() != 'windows' and get_option('enable-nnstreamer-backbone') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script contains the code if get_option('enable-nnstreamer-backbone') and get_option('platform') != 'android' extra_defines += '-DENABLE_NNSTREAMER_BACKBONE=1' endif.
How about merging this part as well? It seems like it would be fine to move the part extra_defines += '-DENABLE_NNSTREAMER_BACKBONE=1' under this condition, too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI) line 407-409
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted back to not moving subdir('nnstreamer') to the earlier stage of meson.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
129daaf to
e11e208
Compare
|
According to discussion made from #2930, I believe |
The configuration I've picked here is non-default. This configuration was written to make very minimal thing, with as much things as disabled. Is "should" = "we never really shouldn't build with BLAS disabled on x86 or arm"? Maybe we should consider removing this |
Yes, I believe that would be more appropriate for the current status since we rely all single-precision computations on cblas (for both x86 and arm). And yes, I think we should really consider removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e11e208 to
8d7f075
Compare
This fixes build 'enable-nnstream-backbone' meson option is specified as 'false' Signed-off-by: Piotr Rak <[email protected]>
This fixes build 'enable-tflite-interpreter' meson option is specified as 'false' Signed-off-by: Piotr Rak <[email protected]>
8d7f075 to
bcbd53e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Misc fixes for some of the options disabled by configuration options.
This is step in direction of fixing builds with various configuration options configurations.
Self evaluation:
How to evaluate:
meson setup --native-file=disables.ini
disables.iniwith contents: