Skip to content

Conversation

@piotrrak
Copy link

This PR seperates unit tests as seperate testsuite
This lets runnig it separatly and it will allow to specify meson test_setup for them.

Self evaluation:

  1. Build test: [ ]Passed [ ]Failed [*]Skipped
  2. Run test: [ ]Passed [ ]Failed [*]Skipped

How to evaluate:
meson test -C <builddir> --suite unittests # runs unittests
meson test -C <builddir> --no-suite unittests # runs app tests

Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the scale of the unit tests becomes significantly large in the future, we might consider utilizing the suite feature to organize them into groups. LGTM!!

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @DonghakPark , Could you check if we need chage the ci when this pr is merged?

@jijoongmoon jijoongmoon changed the title Meson unittests suite [Wait for #2962] Meson unittests suite Mar 8, 2025
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! & @jijoongmoon Okay. I will test CI

This makes it possible to run all unit tests with:
meson test -C <builddir> --suite=unittests

Signed-off-by: Piotr Rak <[email protected]>
Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jijoongmoon jijoongmoon merged commit c9828f7 into nnstreamer:main Mar 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants