[application] namespace duplication in llama application @open sesame 03/07 15:57 #2989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baek2sm
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
djeong20,
dkjung,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
jijoongmoon,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
baek2sm
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
baek2sm
changed the title
baek2sm
changed the title
|
Just a thought, but it seems that instead of using qualified names ie. namespace custom {
using namespace nntrainer;
///... rest mostly without changes
}And leaving this code with unqualified names should be sufficient, with little change/none of the code churn. |
baek2sm
force-pushed
the
llama_namespace
branch
2 times, most recently
from
08b37d1 to
6d7f896
Compare
I applied it, thanks :) |
baek2sm
changed the title
baek2sm
changed the title
baek2sm
changed the title
Previously, the `multi_head_attention_layer` is seperated into a custom layer called `custom_multi_head_attention_layer` for refactoring purposes. At that time, the custom layer header macro and namespace should be changed, but they were copied over as-is, causing duplication. So I've removed the header macro and renamed namespace. Even after resolving this problem, the llama application still does not work properly now. It seems that several issues have arisen due to the reflection of application refactoring and modifications to the nntrainer core. I will resolve these issues as soon as possible. **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [ ]Passed [ ]Failed [X]Skipped Signed-off-by: Seungbaek Hong <[email protected]>
baek2sm
force-pushed
the
llama_namespace
branch
from
6d7f896 to
6aca1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
multi_head_attention_layeris seperated into a custom layer calledcustom_multi_head_attention_layerfor refactoring purposes. At that time, the namespace of custom layer should be changed, but they were copied over as-is, causing duplication. I've renamed namespace.This issue was discovered and reported by @gkisalapl . I always appreciate your efforts. thanks a lot!
Even after resolving this problem, the llama application still does not work properly now.
I'll try to resolve this issue as soon as possible.
Self evaluation: