Fix Ubuntu build with OpenBLAS as subproject #2997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrrak
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
baek2sm,
djeong20,
dkjung,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
jijoongmoon,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
|
@gkisalapl Fine for windows? |
For linux (Ubuntu) it is best if we build OpenBLAS as shared library. If system OpenBLAS is availble it will be used. Signed-off-by: Piotr Rak <[email protected]>
piotrrak
force-pushed
the
linux-blas-subproject
branch
from
093999e to
0e34a8f
Compare
|
Fixed typo s/ |
gkisalapl
approved these changes
Mar 7, 2025
djeong20
approved these changes
Mar 10, 2025
skykongkong8
approved these changes
Mar 10, 2025
If and only if we'd provide Android NDK based standalone toolchain and https://developer.android.com/ndk/guides/other_build_systems and meson toolchain definition to allow cross compilation for android. |
myungjoo
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for Ubuntu when OpenBLAS is build as subproject
Resolves: #2996
Self evaluation:
How to evaluate:
Not applicable