[gtest] Enable gtest built as subproject on linux #3000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googletest provided as CMake subproject requires both gtest_dep and gtest_main_dep Also it should be built with PIC (Position Independent Code) when built as static library Signed-off-by: Piotr Rak <[email protected]>
piotrrak
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
baek2sm,
djeong20,
dkjung,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
jijoongmoon,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
|
@gkisalapl FYI |
gkisalapl
approved these changes
Mar 10, 2025
@piotrrak I think that everyone wanted to make PR number 3000, congratulations ! |
|
Idk, It's not ęven round number log2(3000) is ~11.55 |
I'm so jealous... |
|
Does this fix an error? |
dkjung
approved these changes
Mar 11, 2025
When there're no google test installed on system (linux) build will fail without this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
googletest provided as CMake subproject requires both gtest_dep and gtest_main_dep Also it should be built with PIC (Position Independent Code) when built as static library
Self evaluation:
How to evaluate:
Not applicable (if possible remove system googletest and build)