Skip to content

[FC] Minor fix in FC layer #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

[FC] Minor fix in FC layer #3002

merged 1 commit into from
Mar 11, 2025

Conversation

@EunjuYang
Copy link
Contributor

  • Fix redundant code lines in fc_layer

Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

@EunjuYang
[FC] Minor fix in FC layer
3ffc61f 
- Redundant code fix in FC layer

Signed-off-by: Eunju Yang <[email protected]>
skykongkong8
skykongkong8 approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler the better!

DonghakPark
DonghakPark approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch. LGTM!

dkjung
dkjung approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@dkjung dkjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhs8928
lhs8928 approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@lhs8928 lhs8928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit 9c0c43e into nnstreamer:main Mar 11, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkjung dkjung dkjung approved these changes

@lhs8928 lhs8928 lhs8928 approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 is a code owner

@haehun haehun Awaiting requested review from haehun haehun is a code owner

Assignees

No one assigned

Labels

PR/READY2MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@EunjuYang @dkjung @lhs8928 @DonghakPark @skykongkong8 @jijoongmoon